lp:~makyo/juju-gui/charm-panel-border
- Get this branch:
- bzr branch lp:~makyo/juju-gui/charm-panel-border
Branch merges
- Brad Crittenden (community): Approve (code)
-
Diff: 82 lines (+20/-4)1 file modifiedlib/views/stylesheet.less (+20/-4)
Related bugs
Bug #1077006: Charm panel left border should be 2px as per UX design | High | Fix Released |
Related blueprints
Branch information
Recent revisions
- 236. By Madison Scott-Clary
-
Lightweight assets/improve FF performance
Some lighter weight assets for service modules were implemented, via Matt C. Additionally, profiling showed that a lot of slowness for FireFox was caused by FF internals being slow (namely <node>.
setAttribute( ) and <node>. getClientRects( )). While we can't fix those being slow, we can reduce the number of times they're used. This is done by modifying attributes on only relevant relation lines when a service is dragged (rather than redrawing or modifying all lines). This results in fewer calls to both of those internals, and speeds up animation in FireFox. R=gary.poster, benjamin.saller
CC=
https://codereview. appspot. com/6826057 - 235. By Thiago Veronezi
-
Resource minification/
aggregation js * We should aggregate and minimize the js sources in order to improve the load speed of the application;
* We dont want to use the yui combo loader feature;
* The final product will provide three js files: one for the YUI dependencies, one for our custom js code and one for third part js like d3.R=benji, gary.poster
CC=
https://codereview. appspot. com/6821090 - 234. By Francesco Banconi
-
Charm config panel visual design fixes.
The charm configuration panel now should match UX wireframe.
This branch also contains fixes to the configuration
section hiding when a config file is uploaded.
Also introduced LESS mixins for border radii and box shadows.
Added "docstrings" to relevant charm panel methods.R=bac, gary.poster
CC=
https://codereview. appspot. com/6827066 - 232. By Thiago Veronezi
-
Generic show view event
Instead of wrapping the 'navigate' method call with multiple 'show' events, we want call the 'navigate' method from a single event.
So, instead of...
this.on(
'*:showService' , this.navigate_ to_service) ;
this.on('*:showUnit' , this.navigate_ to_unit) ;
this.on('*:showCharm' , this.navigate_ to_charm) ;
this.on('*:showEnvironm ent', this.navigate_ to_environment) ; ... we will have...
this.on(
'*:navigateTo' , function(e) {
console.log('navigateTo ', e);
this.navigate(e.url);
}, this);R=benji, bac
CC=
https://codereview. appspot. com/6819104 - 231. By Brad Crittenden
-
Style charm results panel.
Does not include filter dropdown as that design is not finalized.
Added further styling as specified by Matt.
- 230. By Brad Crittenden
-
Style charm results panel.
Does not include filter dropdown as that design is not finalized.
R=gary.poster, francesco.banconi
CC=
https://codereview. appspot. com/6817101 - 229. By Brad Crittenden
-
Button corner CSS tweaks.
Changes suggested by Matt to get closer to image assets.
Self-reviewed.
- 228. By Francesco Banconi
-
Charm panel description design.
R=bac, gary.poster
CC=
https://codereview. appspot. com/6819098
Branch metadata
- Branch format:
- Branch format 7
- Repository format:
- Bazaar repository format 2a (needs bzr 1.16 or later)
- Stacked on:
- lp:juju-gui/experimental