Merge lp:~mago-contributors/mago/fix_suite_args into lp:~mago-contributors/mago/mago-1.0

[Ara Pulido]

[Ara Pulido (ara)]

Fixes 399679.

It is a small fix, but I would like it to be reviewed by the people more involved with the "discovery" changes.

Thanks,
Ara.

[Nagappan Alagappan (nagappan)]

> Fixes 399679.
>
> It is a small fix, but I would like it to be reviewed by the people more
> involved with the "discovery" changes.
>
Please commit

Thanks

[Eitan Isaacson (eeejay)]

Looks simple and correct.

review: Approve

[Javier Collado (javier.collado)]

Looks fine. Thanks for the fix.

The args property in the XmlData class creates a dictionary based on the args tag children, so it makes sense that the dictionary is passed to the test suite class __init__ method with '**' instead of with '*'. I wonder why no problem was noticed before.

review: Approve

=== modified file 'mago/cmd/discovery.py'
--- mago/cmd/discovery.py	2009-06-26 12:21:53 +0000
+++ mago/cmd/discovery.py	2009-07-15 11:02:20 +0000
@@ -194,7 +194,7 @@
         module = imp.load_module(module_name, *load_args)
 
         cls = getattr(module, class_name)
-        return cls(*self.args)
+        return cls(**self.args)
 
     
     def get_log_filename(self, application_target_directory):