Merge lp:~mago-applications/mago/mago-reorganize-applications into lp:~mago-contributors/mago/mago-1.0

Proposed by Jeff Lane 
Status: Merged
Merged at revision: 128
Proposed branch: lp:~mago-applications/mago/mago-reorganize-applications
Merge into: lp:~mago-contributors/mago/mago-1.0
Diff against target: 0 lines
To merge this branch: bzr merge lp:~mago-applications/mago/mago-reorganize-applications
Reviewer Review Type Date Requested Status
Nagappan Alagappan Approve
Review via email: mp+28686@code.launchpad.net

Description of the change

Somehow, this branch got merged before it was ready... the latest revno for my changes is 128. Please take a look at the changes and let me know if you agree.

After discussion with Leo and Ara, I went through mago and separated out all the pieces of gnome.py and ubuntu.py into individual application files. The reason for this was that putting them into arbitrary single files will become unweildy and could make maintaining the various tests confusing.

Also, you run into the question of "what is an Ubuntu app?"

So, all separated tests have been tested by me and work (except for Update Manager, but that's another issue as that test has never worked for me).

To post a comment you must log in.
Revision history for this message
Nagappan Alagappan (nagappan) wrote :

Preview Diff and Unmerged revisions doesn't have any link, this will appear only on diff, rather than a new repository ?

Thanks

Revision history for this message
Jeff Lane  (bladernr) wrote :

Yeah, somehow, someone merged my branch before I had finished and commited all the changes... and definitely before I made the merge request....

Revision history for this message
Nagappan Alagappan (nagappan) wrote :

Based on the above comment, let me approve this review request.

Thanks

review: Approve

Preview Diff

Empty

Subscribers

People subscribed via source and target branches

to status/vote changes: