Merge lp:~madsa/slingshot/fix-app-focus into lp:~elementary-pantheon/slingshot/trunk

Proposed by Matt Spaulding on 2016-10-02
Status: Rejected
Rejected by: Zisu Andrei on 2016-11-10
Proposed branch: lp:~madsa/slingshot/fix-app-focus
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 23 lines (+2/-4)
1 file modified
lib/synapse-core/common-actions.vala (+2/-4)
To merge this branch: bzr merge lp:~madsa/slingshot/fix-app-focus
Reviewer Review Type Date Requested Status
elementary Pantheon team 2016-10-02 Pending
Review via email: mp+307382@code.launchpad.net
To post a comment you must log in.
Cody Garver (codygarver) wrote :

This doesn't fix the problem for me, I used Calculator as a test and the behavior is unchanged. It starts focused, then goes unfocused.

Matt Spaulding (madsa) wrote :

I didn't test with Calculator, but for me when I run Calculator it is focused with or without the patch. I don't seem to have a problem with that one. And I'll also note that the loss of focus only happens when another window is already open.

The two apps I really see a problem with are Terminal and AppCenter. The other apps I've tried now don't seem to have the focus problem. You might try testing with those two.

Zisu Andrei (matzipan) wrote :

Rejecting since it did not fix the issue for Cody.

Unmerged revisions

696. By Matt Spaulding on 2016-10-02

Fix app focus when opening from search

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lib/synapse-core/common-actions.vala'
2--- lib/synapse-core/common-actions.vala 2014-06-04 19:35:44 +0000
3+++ lib/synapse-core/common-actions.vala 2016-10-02 05:17:22 +0000
4@@ -93,8 +93,7 @@
5
6 try
7 {
8- var display = Gdk.Display.get_default ();
9- app.launch (null, display.get_app_launch_context ());
10+ app.launch (null, null);
11
12 RelevancyService.get_default ().application_launched (app);
13 }
14@@ -152,8 +151,7 @@
15 AppInfo app = AppInfo.create_from_commandline (
16 original.get_commandline (), original.get_name (),
17 AppInfoCreateFlags.NEEDS_TERMINAL);
18- var display = Gdk.Display.get_default ();
19- app.launch (null, display.get_app_launch_context ());
20+ app.launch (null, null);
21 }
22 catch (Error err)
23 {

Subscribers

People subscribed via source and target branches