Merge lp:~madsa/slingshot/fix-1630852 into lp:~elementary-pantheon/slingshot/trunk

Proposed by Matt Spaulding on 2016-10-06
Status: Rejected
Rejected by: Daniel Fore on 2016-10-07
Proposed branch: lp:~madsa/slingshot/fix-1630852
Merge into: lp:~elementary-pantheon/slingshot/trunk
Diff against target: 11 lines (+1/-1)
1 file modified
src/Widgets/SearchView.vala (+1/-1)
To merge this branch: bzr merge lp:~madsa/slingshot/fix-1630852
Reviewer Review Type Date Requested Status
Daniel Fore 2016-10-06 Disapprove on 2016-10-07
Review via email: mp+307789@code.launchpad.net
To post a comment you must log in.
Daniel Fore (danrabbit) wrote :

Instead of removing it, we should just truncate (max_width_chars) and ellipsize.

review: Needs Fixing
Daniel Fore (danrabbit) wrote :

Marking this branch as rejected since it seems like we need to fix in granite since the label is not public

review: Disapprove

Unmerged revisions

696. By Matt Spaulding on 2016-10-06

Remove search term text from no results view

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/Widgets/SearchView.vala'
2--- src/Widgets/SearchView.vala 2016-07-05 20:18:20 +0000
3+++ src/Widgets/SearchView.vala 2016-10-06 04:31:14 +0000
4@@ -146,7 +146,7 @@
5
6 stack.set_visible_child_name ("results");
7 } else {
8- alert_view.title = _("No Results for ā€œ%sā€".printf (search_term));
9+ alert_view.title = _("No Results");
10 stack.set_visible_child_name ("alert");
11 }
12

Subscribers

People subscribed via source and target branches