Merge lp:~madmuffin/colourterm/autocomplete_ports into lp:colourterm

[Patrick Brueckner]

Autocomplete Ports using pyserials tools-method. Requires pyserial 2.6 or higher.

[Raoul Snyman (raoul-snyman)]

The new functions should be in ConnectDialog, not in Ui_ConnectDialog. Additionally, the method names should match the naming conventions of the rest of the methods in the class.

review: Needs Fixing

[Patrick Brueckner (madmuffin)]

Please re-review.

review: Needs Resubmitting

[Patrick Brueckner (madmuffin)]

review: Approve

[Raoul Snyman (raoul-snyman)]

review: Approve

=== modified file 'colourterm/connectdialog.py'
--- colourterm/connectdialog.py	2013-12-05 14:16:09 +0000
+++ colourterm/connectdialog.py	2013-12-10 06:29:57 +0000
@@ -1,8 +1,9 @@
 # -*- coding: utf-8 -*-
-
+import os
 from PyQt4 import QtCore, QtGui
-from serial import FIVEBITS, SIXBITS, SEVENBITS, EIGHTBITS, PARITY_NONE, PARITY_EVEN, PARITY_ODD, PARITY_MARK,\
-    PARITY_SPACE, STOPBITS_ONE, STOPBITS_ONE_POINT_FIVE, STOPBITS_TWO
+from serial import Serial, FIVEBITS, SIXBITS, SEVENBITS, EIGHTBITS, PARITY_NONE, PARITY_EVEN, PARITY_ODD, PARITY_MARK,\
+    PARITY_SPACE, STOPBITS_ONE, STOPBITS_ONE_POINT_FIVE, STOPBITS_TWO, SerialException
+from serial.tools import list_ports
 
 from colourterm import fromUtf8, translate
 
@@ -36,9 +37,9 @@
         self.portLabel = QtGui.QLabel(connectDialog)
         self.portLabel.setObjectName(fromUtf8('portLabel'))
         self.deviceLayout.addWidget(self.portLabel, 0, 0, 1, 1)
-        self.portEdit = QtGui.QLineEdit(connectDialog)
-        self.portEdit.setText(fromUtf8('/dev/ttyUSB0'))
+        self.portEdit = QtGui.QComboBox(connectDialog)
         self.portEdit.setObjectName(fromUtf8('portEdit'))
+        self.portEdit.setEditable(True)
         self.deviceLayout.addWidget(self.portEdit, 0, 1, 1, 1)
         self.baudLabel = QtGui.QLabel(connectDialog)
         self.baudLabel.setObjectName(fromUtf8('baudLabel'))
@@ -151,7 +152,6 @@
         self.readingCheckBox.setText(translate('ConnectDialog', 'Reading'))
         self.writingCheckBox.setText(translate('ConnectDialog', 'Writing'))
 
-
 class ConnectDialog(QtGui.QDialog, Ui_ConnectDialog):
 
     def __init__(self):
@@ -159,7 +159,7 @@
         self.setupUi(self)
 
     def getPort(self):
-        return unicode(self.portEdit.text())
+        return unicode(self.portEdit.currentText())
 
     def getBaud(self):
         return int(unicode(self.baudComboBox.currentText()))
@@ -178,3 +178,33 @@
 
     def getHardwareHandshake(self):
         return self.hardwareCheckBox.isChecked()
+
+    def updatePortCombobox(self):
+        self.portEdit.clear()
+        ports = []
+        for port in self._getSerialPorts():
+            ports.append(port)
+        ports.sort()
+        self.portEdit.addItems(ports)
+
+    def _getSerialPorts(self):
+        """
+        Returns a generator for all available serial ports
+        """
+        if os.name == 'nt':
+            # windows
+            for i in range(256):
+                try:
+                    s = Serial(i)
+                    s.close()
+                    yield 'COM' + str(i + 1)
+                except SerialException:
+                    pass
+        else:
+            # unix
+            try:
+                for port in list_ports.comports():
+                    yield port[0]
+            except NameError:
+                # pyserial 2.6 cannot handle serial usb ports very well, in that case just do not provide a list
+                pass

=== modified file 'colourterm/mainwindow.py'
--- colourterm/mainwindow.py	2013-12-05 14:16:09 +0000
+++ colourterm/mainwindow.py	2013-12-10 06:29:57 +0000
@@ -1,4 +1,5 @@
 # -*- coding: utf-8 -*-
+import os
 import threading
 
 from PyQt4 import QtCore, QtGui
@@ -166,6 +167,7 @@
                 output = ''
 
     def onOpenActionTriggered(self):
+        self.connectDialog.updatePortCombobox()
         if self.connectDialog.exec_() == QtGui.QDialog.Accepted:
             if not self.deviceClosed:
                 self.deviceClosed = True
@@ -239,7 +241,7 @@
             self.sendComboBox.insertItem(0, output)
             self.sendComboBox.setCurrentIndex(0)
             self.sendComboBox.clearEditText()
-            self.device.write(output + u'\r\n')
+            self.device.write(output + '\r\n')
 
     def onContentsSizeChanged(self, size):
         if self.followOutput:
@@ -291,13 +293,13 @@
                     style = u'%sbackground-color: %s; ' % (style, highlight.background)
                 break
         if style:
-	  try:
-	    output = u'<div style="%s">%s</div>' % (style, unicode(output, u'utf-8'))
-	  except TypeError: 
-	    output = u'<div style="%s">%s</div>' % (style, output)
+            try:
+                output = u'<div style="%s">%s</div>' % (style, unicode(output, u'utf-8'))
+            except TypeError:
+                output = u'<div style="%s">%s</div>' % (style, output)
         else:
             output = u'<div>%s</div>' % output
-	return output
+        return output
 
     def saveHighlights(self, highlights):
         settings = QtCore.QSettings()