> Hi Valentin, > > Thanks for this review. > > > So the case of lhapdf not being used should be better handled. > > > We actually do not need to run with lhapdf, just to have the lhapdf (version6) > available. I know what I meant was that if I don't have lhapdf (or only lhapdf5) on my system, then systematics crashes with the following message: UnboundLocalError : local variable 'lhapdf_libdir' referenced before assignment ( File "/Users/valentin/Documents/Work/MG5/python_syscalc/madgraph/various/misc.py", line 1637, in import_python_lhapdf candidates=[dirname for dirname in os.listdir(lhapdf_libdir+'64') \) It would be nice if this situation could be detected before the crash and if a message would pop up warning the user that systematics are bypassed because he doesn't have lhapdf and that once he will have installed it, he can still rerun systematics independently on his results already produced by using the interactive madevent interface. > > > Also, in the run_card, the commentary of the entry > > NNPDF23_nlo_as_0116_mc = sys_pdf # matching scales > > is not correct > > > fixed > > > It seems that putting the LHAID works as well as putting > > directly the name of the pdf. Is this also true when using the old C++ > > syscalc? > > The commentary of this entry should clarify this point. > > This is not a valid input for SysCalc. So I will not mention it here. Ok, and it would be indeed to complicated to explain in which situation the user can put an lhaid there, I agree. Too bad. > > Also, when putting a PDF set in 'sys_pdf' that I don't have, the codes > > doesn't try to download it (unless of course this is also the PDF set that > > I want to use for my central value). > > It would be a nice feature if it did, because as of now the code simply > > crashes when doing the systematics. > > Done. I also automatically load the central if the run was not performed with > lhapdf. > (knowing that nnpdf is likely to be slightly off due to their bug in lhapdf.) Excellent, I tested it and it works. > > The help of the command 'systematics' is nice. I would maybe rephrase the > > message > > Done > > > pdfset = lhapdf.mkPDF(int(data)).set() > > File "lhapdf.pyx", line 469, in lhapdf.mkPDF (lhapdf.cpp:7253) > > File "lhapdf.pyx", line 454, in lhapdf.mkPDF_lhaid (lhapdf.cpp:7044) > > RuntimeError: Empty PDF file name given to Info::load > > I do not reproduce this. Looks like either some PDF sets are missing or > (worse) corrupted > I have face as well some problem with some lhapdf set so I have use another > method > to load them and it fixes the problem that i faced. Ok, now at NLO, I crash on: AttributeError : 'Event' object has no attribute 'nloweight' [...] File "/Users/valentin/Documents/Work/MG5/python_syscalc/madgraph/various/systematics.py", line 583, in get_nlo_wgt nloinfo = event.parse_nlo_weight() File "/Users/valentin/Documents/Work/MG5/python_syscalc/madgraph/various/lhe_parser.py", line 1134, in parse_nlo_weight return self.nloweight AttributeError: 'Event' object has no attribute 'nloweight' This happened both with and without PDF variations in my generation (I assume you require the user to having generated events with both variations turned on, it would be great if you could safe-check this). By the way, additional general question: If there is already a bunch of weights in the event, but only some are missing given the inputs provided to 'systematics', will you recompute all of them or do you automatically filter them out? It's ok if you recompute all of them, but I was wondering if you had optimized this bit. Cheers, > > Cheers, > > Olivier > > > > > > On Aug 19, 2016, at 07:21, Valentin Hirschi