Hi Valentin, Thanks for this review. > So the case of lhapdf not being used should be better handled. We actually do not need to run with lhapdf, just to have the lhapdf (version6) available. > Also, in the run_card, the commentary of the entry > NNPDF23_nlo_as_0116_mc = sys_pdf # matching scales > is not correct fixed > It seems that putting the LHAID works as well as putting > directly the name of the pdf. Is this also true when using the old C++ > syscalc? > The commentary of this entry should clarify this point. This is not a valid input for SysCalc. So I will not mention it here. > Also, when putting a PDF set in 'sys_pdf' that I don't have, the codes > doesn't try to download it (unless of course this is also the PDF set that > I want to use for my central value). > It would be a nice feature if it did, because as of now the code simply > crashes when doing the systematics. Done. I also automatically load the central if the run was not performed with lhapdf. (knowing that nnpdf is likely to be slightly off due to their bug in lhapdf.) > The help of the command 'systematics' is nice. I would maybe rephrase the > message Done > pdfset = lhapdf.mkPDF(int(data)).set() > File "lhapdf.pyx", line 469, in lhapdf.mkPDF (lhapdf.cpp:7253) > File "lhapdf.pyx", line 454, in lhapdf.mkPDF_lhaid (lhapdf.cpp:7044) > RuntimeError: Empty PDF file name given to Info::load I do not reproduce this. Looks like either some PDF sets are missing or (worse) corrupted I have face as well some problem with some lhapdf set so I have use another method to load them and it fixes the problem that i faced. Cheers, Olivier > On Aug 19, 2016, at 07:21, Valentin Hirschi