Merge lp:~maddevelopers/mg5amcnlo/launch_madevent into lp:~maddevelopers/mg5amcnlo/combine_070

[Olivier Mattelaer]

add the launch command in order to run madevent/standalone from the mg5 command line interface.

[Johan Alwall (johan-alwall)]

Hello Olivier,

At the moment, this doesn't seem to work at all:

mg5>launch PROC_sm_0
Command "launch PROC_sm_0" interrupted with error:
KeyError : 'EDITOR'
Please report this bug on https://bugs.launchpad.net/madgraph5
Traceback (most recent call last):
  File "/Users/alwall/MadGraph/launch_madevent/madgraph/interface/extended_cmd.py", line 151, in onecmd
    return cmd.Cmd.onecmd(self, line)
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/cmd.py", line 219, in onecmd
    return func(arg)
  File "/Users/alwall/MadGraph/launch_madevent/madgraph/interface/cmd_interface.py", line 2215, in do_launch
    ext_program = launch_ext.MELauncher(args[1], self.timeout, **options)
  File "/Users/alwall/MadGraph/launch_madevent/madgraph/interface/launch_ext_program.py", line 177, in __init__
    ExtLauncher.__init__(self, running_dir, './Cards', timeout, **option)
  File "/Users/alwall/MadGraph/launch_madevent/madgraph/interface/launch_ext_program.py", line 44, in __init__
    self.found_editor()
  File "/Users/alwall/MadGraph/launch_madevent/madgraph/interface/launch_ext_program.py", line 57, in found_editor
    if os.environ['EDITOR']:
  File "/System/Library/Frameworks/Python.framework/Versions/2.6/lib/python2.6/UserDict.py", line 22, in __getitem__
    raise KeyError(key)
KeyError: 'EDITOR'

Also, after this error, it's impossible to exit MG5 (except by pressing Ctrl-c)

Johan

review: Needs Fixing

[Johan Alwall (johan-alwall)]

In fact, it's not possible to exit mg5 even before this error is thrown, with quit, exit, or Ctrl-d (only Ctrl-c works).

[Johan Alwall (johan-alwall)]

By setting the environment variable EDITOR, I got it to work. Very nice implementation!
Very cool that it asks for the number of cores when running with multicore.
I haven't tested with cluster running, but I'm sure it also works just fine.

Suggestion:
- If EDITOR is not set, ask for user preference, and store this somewhere so you don't need to ask again (e.g. in a $HOME/.mg5preferences file)

Other comments:
The only other major problem I have found is that it's impossible to exit from MG5, as I mentioned above. Also of course path completion doesn't work, but I assume that's just because this branch doesn't have that fixed yet.

Cheers,
Johan

review: Needs Fixing

[lp:~maddevelopers/mg5amcnlo/launch_madevent]

86. By Olivier Mattelaer on 2011-03-16

fix problem if EDITOR is not define.
fix the Ctr-D problem

[Olivier Mattelaer (olivier-mattelaer)]

I Johan,

Thanks a lot for finding this problem (EDITOR was always define on my computer)

Suggestion:
- If EDITOR is not set, ask for user preference, and store this somewhere so you don't need to ask again (e.g. in a $HOME/.mg5preferences file)

If EDITOR is not set, I prefer to do this:
1) print a message:
INFO: You can choose your prefered editor by defining the shell variable EDITOR
2) use the first program defined in the following list:
['vi', 'emacs', 'vim', 'gedit', 'nano']

The second bug was in fact already fix in the combine_070 branches, but I put the modification here.

[Johan Alwall (johan-alwall)]

Very nice, now it seems to work great! Just a very minor detail - could the default run names correspond to those on the web, i.e., run_01, run_02 etc?

Great, include this in the combine_0_7_0 branch, and then we'll have a final overall review of the branch.

[Olivier Mattelaer (olivier-mattelaer)]

It's run1, run2,...

=== modified file 'madgraph/interface/cmd_interface.py'
--- madgraph/interface/cmd_interface.py	2011-03-15 12:57:11 +0000
+++ madgraph/interface/cmd_interface.py	2011-03-16 09:18:32 +0000
@@ -199,9 +199,15 @@
                 logger_tuto.info(getattr(tutorial_text, args[0]).replace('\n','\n\t'))
             except:
                 pass
+<<<<<<< TREE
         
         return stop
 
+=======
+        
+        return stop
+            
+>>>>>>> MERGE-SOURCE
     def timed_input(self, question, default, timeout=None):
         """ a question with a maximal time to answer take default otherwise"""
         

=== modified file 'madgraph/interface/launch_ext_program.py'
--- madgraph/interface/launch_ext_program.py	2011-03-15 09:38:24 +0000
+++ madgraph/interface/launch_ext_program.py	2011-03-16 09:18:32 +0000
@@ -54,15 +54,20 @@
         # let first try to use the prefer editor (if EDITOR is define)
         # if not define use the first define in a pre-define list
             
-        if os.environ['EDITOR']:
+        if os.environ.has_key('EDITOR') and misc.which(os.environ['EDITOR']):
             self.editor =  os.environ['EDITOR']
             return
         
+        logger.info('INFO: You can choose your prefered editor by defining the shell variable EDITOR')
+        
         possibility = ['vi', 'emacs', 'vim', 'gedit', 'nano']
         for editor in possibility:
             if misc.which(editor):
                 self.editor = editor
                 return
+        
+        logger.warning(
+         'No valid editor detected. Please configure the shell variable EDITOR')
             
     def run(self):
         """ execute the main code """
@@ -86,6 +91,7 @@
         """edit a file"""
 
         path = os.path.realpath(path)
+        print [self.editor, path], os.getcwd()
         subprocess.call([self.editor, path], cwd=os.getcwd())
         
     def ask(self, question, default):

=== modified file 'madgraph/iolibs/misc.py'
--- madgraph/iolibs/misc.py	2011-03-10 13:12:33 +0000
+++ madgraph/iolibs/misc.py	2011-03-16 09:18:32 +0000
@@ -86,6 +86,9 @@
     def is_exe(fpath):
         return os.path.exists(fpath) and os.access(fpath, os.X_OK)
 
+    if not program:
+        return None
+
     fpath, fname = os.path.split(program)
     if fpath:
         if is_exe(program):