Merge lp:~maddevelopers/mg5amcnlo/fix_fermion_order_interaction into lp:~madteam/mg5amcnlo/trunk

[Johan Alwall]

Ensure that the order of particles/antiparticles in interactions doesn't matter by calling hermitian conjugate function if the call (based on I/O) is using the wrong order compared to the original interaction.

[lp:~maddevelopers/mg5amcnlo/fix_fermion_order_interaction]

201. By Johan Alwall on 2012-01-26

Removed some commented lines and stupid additions to parallel tests, fixed VERSION and UpdateNotes.

[Olivier Mattelaer (olivier-mattelaer)]

I would suggest to add an automatic flipping between particle/anti-particle to avoid the need of the C routine as much as possible. (I have one implemented, so I can put it here if you aggree.

The point is that this slows down (marginally) the creation of the pickle file (so only once)
and this prevents the C routine to be used in 99% of the case.

[Johan Alwall (johan-alwall)]

Hello Olivier,

Sure, this would be a nice additional measure. But I'm not sure it would help in all cases, e.g. when you have two particles or two anti-particles in an interaction.

What is the reason to avoid the C routine as much as possible? Does it slow down the code?

[Olivier Mattelaer (olivier-mattelaer)]

> Hello Olivier,
>
> Sure, this would be a nice additional measure. But I'm not sure it would help
> in all cases, e.g. when you have two particles or two anti-particles in an
> interaction.
>
> What is the reason to avoid the C routine as much as possible? Does it slow
> down the code?

The code is more optimal if we don't have both C and regular routine. But this is not critical at all. But since I did it...

Otherwise the parralel test has some failure:

first:

ERROR: test_mg5_heft_23 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a heft 2->3 processes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 441, in test_mg5_heft_23
    self.compare_MG4_MG5(my_proc_list,
AttributeError: 'OLDMG5Comparator' object has no attribute 'compare_MG4_MG5'

which looks like a problem of the test in itself

Then
======================================================================
ERROR: test_short_mssm (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a minimal list of mssm 2->2 processes, mainly to test the test
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 245, in test_short_mssm
    stored_runner.energy)
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_comparator.py", line 682, in run_comparison
    self.results.append(runner.run(proc_list, model[i], orders, energy))
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_comparator.py", line 394, in run
    value = self.get_me_value(proc, i)
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_comparator.py", line 265, in get_me_value
    stdout=devnull, stderr=devnull)
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 493, in call
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 679, in __init__
  File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subprocess.py", line 1120, in _execute_child
OSError: [Errno 24] Too many open files

and the same type of error for test_short_sm (but here it fails to copy the template)...

and finally the most problematic one:

======================================================================
FAIL: test_mg5_sm_23 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a semi-complete list of sm 2->3 processes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 338, in test_mg5_sm_23
    filename = "sm_23.log")
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 121, in compare_processes
    my_comp.assert_processes(self, tolerance)
  File "/Users/omatt/Documents/Eclipse...

[Johan Alwall (johan-alwall)]

Hello Olivier,

> > Sure, this would be a nice additional measure. But I'm not sure it would
> help
> > in all cases, e.g. when you have two particles or two anti-particles in an
> > interaction.
> >
> > What is the reason to avoid the C routine as much as possible? Does it slow
> > down the code?
>
> The code is more optimal if we don't have both C and regular routine. But this
> is not critical at all. But since I did it...

We should definitely include your fix too. Just need to do serious parallel tests for both modifications independently, and then together, to be safe. For the last test, I tried running g g > a b b~ standalone, and it runs without problem. So it seems that all the failures below are due to the tests, not the code. Since you wrote these tests, perhaps you could try to fix them? It should be much faster for you than for me.

Thanks!
Johan

> Otherwise the parralel test has some failure:
>
> first:
>
> ERROR: test_mg5_heft_23
> (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
> Test a heft 2->3 processes
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compar
> e_with_old_mg5_version.py", line 441, in test_mg5_heft_23
> self.compare_MG4_MG5(my_proc_list,
> AttributeError: 'OLDMG5Comparator' object has no attribute 'compare_MG4_MG5'
>
> which looks like a problem of the test in itself

Indeed. Did I touch this? If I did, please feel free to revert it. Same thing with the errors below.

>
> Then
> ======================================================================
> ERROR: test_short_mssm
> (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
> Test a minimal list of mssm 2->2 processes, mainly to test the test
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compar
> e_with_old_mg5_version.py", line 245, in test_short_mssm
> stored_runner.energy)
> File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_com
> parator.py", line 682, in run_comparison
> self.results.append(runner.run(proc_list, model[i], orders, energy))
> File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_com
> parator.py", line 394, in run
> value = self.get_me_value(proc, i)
> File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_com
> parator.py", line 265, in get_me_value
> stdout=devnull, stderr=devnull)
> File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subpro
> cess.py", line 493, in call
> File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subpro
> cess.py", line 679, in __init__
> File "/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/subpro
> cess.py", line 1120, in _execute_child
> OSError: [Errno 24] Too many open files
>
> and the same type of error for test_short_sm (but here it fails to copy the
> template)...
>
>
> and finally the most problematic one:
>
> ================================...

[Olivier Mattelaer (olivier-mattelaer)]

I've made the merge in the last version, and it looks better:
but they are some fails (but maybe those one are expected in fact (since I compare to a old MG5))

Cheers,

Olivier

ERROR: test_paralel_cross_sm (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a short list of sm processes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 686, in test_paralel_cross_sm
    filename = "short_cs_sm.log")
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 161, in compare_cross_section
    ['paralel_test_model_%s' % model, model], orders)
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/madevent_comparator.py", line 71, in run_comparison
    self.results.append(runner.run(proc_list, model[i], orders))
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/madevent_comparator.py", line 412, in run
    values = self.get_values()
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/madevent_comparator.py", line 327, in get_values
    SubProc=[name for name in os.listdir(dir_name + '/SubProcesses')
OSError: [Errno 2] No such file or directory: '/Users/omatt/Documents/Eclipse/fix_fermion/parralel_tests_mg5/p_ME_test_v5_ref_0/SubProcesses'

======================================================================
FAIL: test_mg5_mssm_22 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a semi-complete list of mssm 2->2 processes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 589, in test_mg5_mssm_22
    filename = "mssm_22.log")
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 124, in compare_processes
    my_comp.assert_processes(self, tolerance)
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/me_comparator.py", line 810, in assert_processes
    test_object.assertEqual(fail_str, "Failed for processes:")
AssertionError: 'Failed for processes:\na a > x1- x2+ 1.9918958496e-34 4.7490497800e-41 9.9999952316e-01 \na a > x1+ x2- 1.9918958496e-34 4.7490497800e-41 9.9999952316e-01 ' != 'Failed for processes:'

======================================================================
FAIL: test_mg5_mssm_23_p2 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
Test a semi-complete list of mssm 2->3 processes
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 649, in test_mg5_mssm_23_p2
    filename = "mssm_23_p2.log")
  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/compare_with_old_mg5_version.py", line 124, in compare_processes
    my_comp.assert_processes(self, tolerance)
  File "/Use...

[Johan Alwall (johan-alwall)]

Hello Olivier,

> ERROR: test_paralel_cross_sm (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
> Test a short list of sm processes
> ----------------------------------------------------------------------
>  File "/Users/omatt/Documents/Eclipse/fix_fermion/tests/parallel_tests/madevent_comparator.py", line 327, in get_values
>    SubProc=[name for name in os.listdir(dir_name + '/SubProcesses')
> OSError: [Errno 2] No such file or directory: '/Users/omatt/Documents/Eclipse/fix_fermion/parralel_tests_mg5/p_ME_test_v5_ref_0/SubProcesses'

This definitely looks like a problem with the test, which needs to be fixed.

> ======================================================================
> FAIL: test_mg5_mssm_22 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
> Test a semi-complete list of mssm 2->2 processes
> ----------------------------------------------------------------------
> AssertionError: 'Failed for processes:\na a > x1- x2+   1.9918958496e-34 4.7490497800e-41 9.9999952316e-01 \na a > x1+ x2-   1.9918958496e-34 4.7490497800e-41 9.9999952316e-01 ' != 'Failed for processes:'

Ah - this looks like a real failure though, and in fact the only process where we do expect failure if there is a problem. So the question is which version is correct.

> ======================================================================
> FAIL: test_mg5_mssm_23_p2 (tests.parallel_tests.compare_with_old_mg5_version.OLDMG5Comparator)
> Test a semi-complete list of mssm 2->3 processes
> ----------------------------------------------------------------------
> AssertionError: 'Failed for processes:\na a > a x1- x2+ 1.8410268017e-40 4.3893499400e-47 9.9999952316e-01 \na a > a x1+ x2- 1.8401745086e-40 4.3873179200e-47 9.9999952316e-01 \na a > a x2- x1+ 1.9670095850e-40 4.6897163000e-47 9.9999952316e-01 \na a > a x2+ x1- 1.9662593729e-40 4.6879276600e-47 9.9999952316e-01 ' != 'Failed for processes:'

Same thing here. I'll take a look.

[Johan Alwall (johan-alwall)]

Hello again,

This is strange - when I compare these processes between the trunk and this branch, I get no difference at all. So it must be a difference between the older and newer versions. Which version are you comparing with?

[Johan Alwall (johan-alwall)]

Hello Olivier,

Aha, you are comparing with the modified mssm (where the PDG code for x1+ is changed)? For regular MSSM I don't get any difference for any version (I've tested down to v. 1.2.3, with identical result for the a a > x1x2 processes).

Cheers,
Johan

[Johan Alwall (johan-alwall)]

Hello again Olivier,

I have looked closer into this. For x1- and x2+ being particles (i.e., flip of sign for x1), the calls for a a > x1- x2+ are:

      CALL VXXXXX(P(0,1),ZERO,NHEL(1),-1*IC(1),W(1,1))
      CALL VXXXXX(P(0,2),ZERO,NHEL(2),-1*IC(2),W(1,2))
      CALL IXXXXX(P(0,3),MCH1,NHEL(3),-1*IC(3),W(1,3))
      CALL OXXXXX(P(0,4),MCH2,NHEL(4),+1*IC(4),W(1,4))
      CALL FFV2C1_3_2(W(1,3),W(1,1),GC_686,GC_652,MCH1, WCH1, W(1,5))
C Amplitude(s) for diagram number 1
      CALL FFV3C1_0(W(1,5),W(1,4),W(1,2),GC_650,AMP(1))
      CALL FFV3C1_2(W(1,3),W(1,1),GC_650,MCH2, WCH2, W(1,6))
C Amplitude(s) for diagram number 2
      CALL FFV2_3_0(W(1,6),W(1,4),W(1,2),GC_686,GC_652,AMP(2))
      CALL FFV3C1_1(W(1,4),W(1,1),GC_650,MCH1, WCH1, W(1,7))
C Amplitude(s) for diagram number 3
      CALL FFV2C1_3_0(W(1,3),W(1,7),W(1,2),GC_686,GC_652,AMP(3))
      CALL FFV2_3_1(W(1,4),W(1,1),GC_686,GC_652,MCH2, WCH2, W(1,8))
C Amplitude(s) for diagram number 4
      CALL FFV3C1_0(W(1,3),W(1,8),W(1,2),GC_650,AMP(4))

This looks completely reasonable to me - all calls involving the x1 are C'ed, but not the calls involving only x2, since x2 is not flipped. However, it seems that in order to get the same answer as the non-flipped mssm, I need to C *all* calls - also the ones involving only x2. So I clearly don't understand how this works. Do you understand it?

Johan

[Olivier Mattelaer (olivier-mattelaer)]

Hi Johan,

I've looked to a a > x1+ x2- (so quite the same up to the sign)
and in that case the matrix.f sounds weird to me:
       CALL VXXXXX(P(0,1),ZERO,NHEL(1),-1*IC(1),W(1,1))
       CALL VXXXXX(P(0,2),ZERO,NHEL(2),-1*IC(2),W(1,2))
       CALL IXXXXX(P(0,3),MCH1,NHEL(3),-1*IC(3),W(1,3))
       CALL OXXXXX(P(0,4),MCH2,NHEL(4),+1*IC(4),W(1,4))
       CALL FFV2_3_2(W(1,3),W(1,1),GC_686,GC_652,MCH1, WCH1, W(1,5))
C Amplitude(s) for diagram number 1
       CALL FFV3C1_0(W(1,5),W(1,4),W(1,2),GC_633,AMP(1))
       CALL FFV3C1_2(W(1,3),W(1,1),GC_633,MCH2, WCH2, W(1,6))
C Amplitude(s) for diagram number 2
       CALL FFV2C1_3_0(W(1,6),W(1,4),W(1,2),GC_686,GC_652,AMP(2))
       CALL FFV3C1_1(W(1,4),W(1,1),GC_633,MCH1, WCH1, W(1,7))
C Amplitude(s) for diagram number 3
       CALL FFV2C1_3_0(W(1,3),W(1,7),W(1,2),GC_686,GC_652,AMP(3))
       CALL FFV2C1_3_1(W(1,4),W(1,1),GC_686,GC_652,MCH2, WCH2, W(1,8))
C Amplitude(s) for diagram number 4
       CALL FFV3C1_0(W(1,3),W(1,8),W(1,2),GC_633,AMP(4))

What is weird is that the routine without any C, is a x1+ x1- a ...
even the routine with the x2+ x2- are with C routine in this case...

So here I don't understand the output at all.

Cheers,

Olivier

On 07-févr.-12, at 01:21, Johan Alwall wrote:

> Hello again Olivier,
>
> I have looked closer into this. For x1- and x2+ being particles
> (i.e., flip of sign for x1), the calls for a a > x1- x2+ are:
>
> CALL VXXXXX(P(0,1),ZERO,NHEL(1),-1*IC(1),W(1,1))
> CALL VXXXXX(P(0,2),ZERO,NHEL(2),-1*IC(2),W(1,2))
> CALL IXXXXX(P(0,3),MCH1,NHEL(3),-1*IC(3),W(1,3))
> CALL OXXXXX(P(0,4),MCH2,NHEL(4),+1*IC(4),W(1,4))
> CALL FFV2C1_3_2(W(1,3),W(1,1),GC_686,GC_652,MCH1, WCH1, W(1,5))
> C Amplitude(s) for diagram number 1
> CALL FFV3C1_0(W(1,5),W(1,4),W(1,2),GC_650,AMP(1))
> CALL FFV3C1_2(W(1,3),W(1,1),GC_650,MCH2, WCH2, W(1,6))
> C Amplitude(s) for diagram number 2
> CALL FFV2_3_0(W(1,6),W(1,4),W(1,2),GC_686,GC_652,AMP(2))
> CALL FFV3C1_1(W(1,4),W(1,1),GC_650,MCH1, WCH1, W(1,7))
> C Amplitude(s) for diagram number 3
> CALL FFV2C1_3_0(W(1,3),W(1,7),W(1,2),GC_686,GC_652,AMP(3))
> CALL FFV2_3_1(W(1,4),W(1,1),GC_686,GC_652,MCH2, WCH2, W(1,8))
> C Amplitude(s) for diagram number 4
> CALL FFV3C1_0(W(1,3),W(1,8),W(1,2),GC_650,AMP(4))
>
> This looks completely reasonable to me - all calls involving the x1
> are C'ed, but not the calls involving only x2, since x2 is not
> flipped. However, it seems that in order to get the same answer as
> the non-flipped mssm, I need to C *all* calls - also the ones
> involving only x2. So I clearly don't understand how this works. Do
> you understand it?
>
> Johan
> --
> https://code.launchpad.net/~maddevelopers/madgraph5/
> fix_fermion_order_interaction/+merge/90246
> You are requested to review the proposed merge of lp:~maddevelopers/
> madgraph5/fix_fermion_order_interaction into lp:madgraph5.

[Johan Alwall (johan-alwall)]

> I've looked to a a > x1+ x2- (so quite the same up to the sign)
Oh, but this is completely different.

> and in that case the matrix.f sounds weird to me:
> CALL VXXXXX(P(0,1),ZERO,NHEL(1),-1*IC(1),W(1,1))
> CALL VXXXXX(P(0,2),ZERO,NHEL(2),-1*IC(2),W(1,2))
> CALL IXXXXX(P(0,3),MCH1,NHEL(3),-1*IC(3),W(1,3))
> CALL OXXXXX(P(0,4),MCH2,NHEL(4),+1*IC(4),W(1,4))

The x1+ is antifermion, so is correctly incoming, while x2-, also an antifermion, is CCed and has fermionflow flag -1 in this process (since it should be incoming but is instead outgoing).

> CALL FFV2_3_2(W(1,3),W(1,1),GC_686,GC_652,MCH1, WCH1, W(1,5))

This should be correct - the x1+ is incoming and is in the right place.

> C Amplitude(s) for diagram number 1
> CALL FFV3C1_0(W(1,5),W(1,4),W(1,2),GC_633,AMP(1))
> CALL FFV3C1_2(W(1,3),W(1,1),GC_633,MCH2, WCH2, W(1,6))

This is charged conjugated because of mismatch of order of fermions.

> C Amplitude(s) for diagram number 2
> CALL FFV2C1_3_0(W(1,6),W(1,4),W(1,2),GC_686,GC_652,AMP(2))
> CALL FFV3C1_1(W(1,4),W(1,1),GC_633,MCH1, WCH1, W(1,7))

This is charged conjugated because the x2- is CCed (fermionflow -1).

> C Amplitude(s) for diagram number 3
> CALL FFV2C1_3_0(W(1,3),W(1,7),W(1,2),GC_686,GC_652,AMP(3))
> CALL FFV2C1_3_1(W(1,4),W(1,1),GC_686,GC_652,MCH2, WCH2, W(1,8))
> C Amplitude(s) for diagram number 4
> CALL FFV3C1_0(W(1,3),W(1,8),W(1,2),GC_633,AMP(4))
>
> What is weird is that the routine without any C, is a x1+ x1- a ...
> even the routine with the x2+ x2- are with C routine in this case...

So everything looks right according to how I understand it. But I am obviously missing something. Perhaps we should ask Tim for help here...

Cheers,
Johan

> On 07-févr.-12, at 01:21, Johan Alwall wrote:
>
> > Hello again Olivier,
> >
> > I have looked closer into this. For x1- and x2+ being particles
> > (i.e., flip of sign for x1), the calls for a a > x1- x2+ are:
> >
> > CALL VXXXXX(P(0,1),ZERO,NHEL(1),-1*IC(1),W(1,1))
> > CALL VXXXXX(P(0,2),ZERO,NHEL(2),-1*IC(2),W(1,2))
> > CALL IXXXXX(P(0,3),MCH1,NHEL(3),-1*IC(3),W(1,3))
> > CALL OXXXXX(P(0,4),MCH2,NHEL(4),+1*IC(4),W(1,4))
> > CALL FFV2C1_3_2(W(1,3),W(1,1),GC_686,GC_652,MCH1, WCH1, W(1,5))
> > C Amplitude(s) for diagram number 1
> > CALL FFV3C1_0(W(1,5),W(1,4),W(1,2),GC_650,AMP(1))
> > CALL FFV3C1_2(W(1,3),W(1,1),GC_650,MCH2, WCH2, W(1,6))
> > C Amplitude(s) for diagram number 2
> > CALL FFV2_3_0(W(1,6),W(1,4),W(1,2),GC_686,GC_652,AMP(2))
> > CALL FFV3C1_1(W(1,4),W(1,1),GC_650,MCH1, WCH1, W(1,7))
> > C Amplitude(s) for diagram number 3
> > CALL FFV2C1_3_0(W(1,3),W(1,7),W(1,2),GC_686,GC_652,AMP(3))
> > CALL FFV2_3_1(W(1,4),W(1,1),GC_686,GC_652,MCH2, WCH2, W(1,8))
> > C Amplitude(s) for diagram number 4
> > CALL FFV3C1_0(W(1,3),W(1,8),W(1,2),GC_650,AMP(4))
> >
> > This looks completely reasonable to me - all calls involving the x1
> > are C'ed, but not the calls involving only x2, since x2 is not
> > flipped. However, it seems that in order to get the same answer as
> > the non-flipped mssm, I need to C *all* ...

[Johan Alwall (johan-alwall)]

Olivier,

Does your fix give the correct result for these processes (without including my fix)? Can you please push it in a separate branch so I can make some comparisons?

Thanks,
Johan

[Olivier Mattelaer (olivier-mattelaer)]

Ok Done,

lp:~maddevelopers/madgraph5/flip_particle_antiparticle

(I was force to re-implement it but ok this is very fast)

I've made the check for
a a > x1+ x2-
a a > x2+ x1-
a a > x1+ x1-

and full agreement the next good point is that this is not intrusive,
since this doesn't change anything to existing model.

So maybe we can push this version in 1.4.2, such that we cover this bug for the moment.

Cheers,

Olivier

review: Needs Fixing

[Olivier Mattelaer (olivier-mattelaer)]

Hi Johan,

should I put my branch under review?

Cheers,

Olivier

[Johan Alwall (johan-alwall)]

> Hi Johan,
>
> should I put my branch under review?

Yes please do :-)

Cheers,
Johan

>
> Cheers,
>
> Olivier

[Olivier Mattelaer (olivier-mattelaer)]

Ok, now that the other branch is going to be merged. I'm closing this review and the associated branch.

review: Disapprove

Unmerged revisions

201. By Johan Alwall on 2012-01-26

Removed some commented lines and stupid additions to parallel tests, fixed VERSION and UpdateNotes.

200. By Johan Alwall on 2012-01-26

Ensure that we get the same result independently of the order of fermion/antifermion in interaction (see bug 921487)

=== modified file 'UpdateNotes.txt'
--- UpdateNotes.txt	2012-01-25 04:09:03 +0000
+++ UpdateNotes.txt	2012-01-26 10:43:23 +0000
@@ -1,6 +1,11 @@
 Update notes for MadGraph 5 (in reverse time order)
 
-1.3.33 (01/01/25) JA: Revisited colors for propagators in addmothers.f
+1.3.34 (27/01/12) JA: Ensure that conjugated wavefunctions are applied
+                      appropriately if the order of fermions and
+                      antifermions is non-standard (in UFO models from
+                      FeynRules, the order is always antifermion,fermion).
+ 
+1.3.33 (25/01/12) JA: Revisited colors for propagators in addmothers.f
                       to ensure that propagators in color flow
                       violating processes get the correct color
                       from initial state particles (thanks to

=== modified file 'madgraph/VERSION'
--- madgraph/VERSION	2012-01-25 03:54:07 +0000
+++ madgraph/VERSION	2012-01-26 10:43:23 +0000
@@ -1,2 +1,2 @@
-version = 1.3.33
-date = 2012-01-25
+version = 1.3.34
+date = 2012-01-27

=== modified file 'madgraph/core/helas_objects.py'
--- madgraph/core/helas_objects.py	2011-11-12 06:29:47 +0000
+++ madgraph/core/helas_objects.py	2012-01-26 10:43:23 +0000
@@ -1167,12 +1167,9 @@
     def get_conjugate_index(self):
         """Return the index of the particle that should be conjugated."""
 
-        if not any([(wf.get('fermionflow') < 0 or wf.is_majorana()) for wf in \
-                    self.get('mothers')]) and \
-                    (not self.get('interaction_id') or \
-                    self.get('fermionflow') >= 0):
+        if not self.get('mothers'):
             return ()
-        
+
         # Pick out first sorted mothers, then fermions
         mothers, self_index = \
                       self.get('mothers').sort_by_pdg_codes(self.get('pdg_codes'),
@@ -1188,13 +1185,17 @@
                              if state != me.get('state')][0])
             fermions.insert(self_index, me)
 
-        # Initialize indices with indices due to Majoranas with wrong order
-        indices = fermions.majorana_conjugates()
+        indices = []
 
         # Check for fermions with negative fermion flow
+        # and for fermions in the wrong order relative to the interaction
         for i in range(0,len(fermions), 2):
             if fermions[i].get('fermionflow') < 0 or \
-               fermions[i+1].get('fermionflow') < 0:
+               fermions[i+1].get('fermionflow') < 0 or \
+               fermions[i].get_spin_state_number() > 0 and \
+               fermions[i+1].get_spin_state_number() < 0 and \
+               fermions[i].get_pdg_code() != \
+               fermions[i+1].get_pdg_code():
                 indices.append(i/2 + 1)
 
         return tuple(sorted(indices))
@@ -2044,22 +2045,22 @@
     def get_conjugate_index(self):
         """Return the index of the particle that should be conjugated."""
 
-        if not any([(wf.get('fermionflow') < 0 or wf.is_majorana()) for wf in \
-                    self.get('mothers')]):
-            return ()
-        
         # Pick out first sorted mothers, then fermions
         mothers, self_index = \
                       self.get('mothers').sort_by_pdg_codes(self.get('pdg_codes'))
         fermions = HelasWavefunctionList([wf for wf in mothers if wf.is_fermion()])
 
-        # Initialize indices with indices due to Majoranas with wrong order
-        indices = fermions.majorana_conjugates()
+        indices = []
 
         # Check for fermions with negative fermion flow
+        # and for fermions in the wrong order relative to the interaction
         for i in range(0,len(fermions), 2):
             if fermions[i].get('fermionflow') < 0 or \
-               fermions[i+1].get('fermionflow') < 0:
+               fermions[i+1].get('fermionflow') < 0 or \
+               fermions[i].get_spin_state_number() > 0 and \
+               fermions[i+1].get_spin_state_number() < 0 and \
+               fermions[i].get_pdg_code() != \
+               fermions[i+1].get_pdg_code():
                 indices.append(i/2 + 1)
                 
         return tuple(sorted(indices))

=== modified file 'tests/parallel_tests/compare_with_old_mg5_version.py'
--- tests/parallel_tests/compare_with_old_mg5_version.py	2011-11-11 22:11:52 +0000
+++ tests/parallel_tests/compare_with_old_mg5_version.py	2012-01-26 10:43:23 +0000
@@ -225,7 +225,7 @@
             my_comp.cleanup()
             
     def test_short_mssm(self):
-        """Test a minimal list of sm 2->2 processes, mainly to test the test"""
+        """Test a minimal list of mssm 2->2 processes, mainly to test the test"""
         # Create a list of processes to check automatically
         comparisons = me_comparator.PickleRunner.find_comparisons(\
             os.path.join(_pickle_path, "mg5_short_parraleltest_mssm.pkl"))
@@ -448,4 +448,4 @@
 
 
 
-        
\ No newline at end of file
+        

=== modified file 'tests/unit_tests/core/test_helas_objects.py'
--- tests/unit_tests/core/test_helas_objects.py	2011-11-09 06:54:38 +0000
+++ tests/unit_tests/core/test_helas_objects.py	2012-01-26 10:43:23 +0000
@@ -2271,8 +2271,8 @@
 
         wfxm.set('state', 'outgoing')
         wfn1.set('state', 'outgoing')
-        # only one Majorana
-        self.assertEqual(wfxm.get_conjugate_index(), ())
+        # only one Majorana, but wrong order compared to interaction
+        self.assertEqual(wfxm.get_conjugate_index(), (1,))
 
         wfxm.set('fermionflow', -1)
         # neg. fermion flow

=== modified file 'tests/unit_tests/iolibs/test_export_v4.py'
--- tests/unit_tests/iolibs/test_export_v4.py	2011-11-12 06:29:47 +0000
+++ tests/unit_tests/iolibs/test_export_v4.py	2012-01-26 10:43:23 +0000
@@ -109,8 +109,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 7,
                       'particles': base_objects.ParticleList(\
-                                            [eminus, \
-                                             eplus, \
+                                            [eplus, \
+                                             eminus, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -2110,8 +2110,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 12,
                       'particles': base_objects.ParticleList(\
-                                            [go, \
-                                             antiu, \
+                                            [antiu, \
+                                             go, \
                                              ul]),
                       'color': [],
                       'lorentz':['L1'],
@@ -2132,8 +2132,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 14,
                       'particles': base_objects.ParticleList(\
-                                            [go, \
-                                             antid, \
+                                            [antid, \
+                                             go, \
                                              dl]),
                       'color': [],
                       'lorentz':['L1'],
@@ -2155,8 +2155,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 16,
                       'particles': base_objects.ParticleList(\
-                                            [n1, \
-                                             antiu, \
+                                            [antiu, \
+                                             n1, \
                                              ul]),
                       'color': [],
                       'lorentz':['L1'],
@@ -2177,8 +2177,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 18,
                       'particles': base_objects.ParticleList(\
-                                            [n1, \
-                                             antid, \
+                                            [antid, \
+                                             n1, \
                                              dl]),
                       'color': [],
                       'lorentz':['L1'],
@@ -5546,7 +5546,7 @@
 
         myinterlist.append(base_objects.Interaction({
             'id': 1,
-            'particles': base_objects.ParticleList([t, antib, wpbar]),
+            'particles': base_objects.ParticleList([antib, t, wpbar]),
             'color': [color.ColorString([color.T(1,0)])],
             'lorentz': ['FFS3', 'FFS4'],
             'couplings': {(0, 0): 'GC_108', (0, 1): 'GC_111'},
@@ -5554,7 +5554,7 @@
             }))
         myinterlist.append(base_objects.Interaction({
             'id': 2,
-            'particles': base_objects.ParticleList([b, antit, wp]),
+            'particles': base_objects.ParticleList([antit, b, wp]),
             'color': [color.ColorString([color.T(1,0)])],
             'lorentz': ['FFS3', 'FFS4'],
             'couplings': {(0, 0): 'GC_108', (0, 1): 'GC_111'},
@@ -5842,8 +5842,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 7,
                       'particles': base_objects.ParticleList(\
-                                            [eminus, \
-                                             eplus, \
+                                            [eplus, \
+                                             eminus, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -5854,8 +5854,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 16,
                       'particles': base_objects.ParticleList(\
-                                            [muminus, \
-                                             muplus, \
+                                            [muplus, \
+                                             muminus, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -6495,7 +6495,7 @@
       PMASS(8)=ZERO\n""")
 
     def test_vector_clash_majorana_process(self):
-        """Test majorana process w+ w- > n2 n2
+        """Test majorana process w+ w- > n1 n1
         """
 
         mypartlist = base_objects.ParticleList()
@@ -6503,7 +6503,7 @@
 
         # Neutralino
         mypartlist.append(base_objects.Particle({'name':'n1',
-                      'antiname':'n2',
+                      'antiname':'n1',
                       'spin':2,
                       'color':1,
                       'mass':'MN1',
@@ -6519,8 +6519,8 @@
         n1 = mypartlist[len(mypartlist) - 1]
 
         # W+/-
-        mypartlist.append(base_objects.Particle({'name':'w-',
-                      'antiname':'w+',
+        mypartlist.append(base_objects.Particle({'name':'w+',
+                      'antiname':'w-',
                       'spin':3,
                       'color':1,
                       'mass':'WMASS',
@@ -6529,7 +6529,7 @@
                       'antitexname':'w+',
                       'line':'wavy',
                       'charge':1.,
-                      'pdg_code':-24,
+                      'pdg_code':24,
                       'propagating':True,
                       'is_part':True,
                       'self_antipart':False}))
@@ -6538,17 +6538,17 @@
         wminus.set('is_part', False)
 
         # chargino+/-
-        mypartlist.append(base_objects.Particle({'name':'x1-',
-                      'antiname':'x1+',
+        mypartlist.append(base_objects.Particle({'name':'x1+',
+                      'antiname':'x1-',
                       'spin':2,
                       'color':1,
                       'mass':'MX1',
                       'width':'WX1',
-                      'texname':'x1-',
-                      'antitexname':'x1+',
+                      'texname':'x1+',
+                      'antitexname':'x1-',
                       'line':'straight',
                       'charge':1.,
-                      'pdg_code':-1000024,
+                      'pdg_code':1000024,
                       'propagating':True,
                       'is_part':True,
                       'self_antipart':False}))
@@ -6560,8 +6560,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 1,
                       'particles': base_objects.ParticleList(\
-                                            [n1, \
-                                             x1minus, \
+                                            [x1minus, \
+                                             n1, \
                                              wplus]),
                       'color': [],
                       'lorentz':[''],
@@ -6571,8 +6571,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 2,
                       'particles': base_objects.ParticleList(\
-                                            [x1plus, \
-                                             n1, \
+                                            [n1, \
+                                             x1plus, \
                                              wminus]),
                       'color': [],
                       'lorentz':[''],
@@ -6610,12 +6610,178 @@
 CALL VXXXXX(P(0,2),WMASS,NHEL(2),-1*IC(2),W(1,2))
 CALL IXXXXX(P(0,3),MN1,NHEL(3),-1*IC(3),W(1,3))
 CALL OXXXXX(P(0,4),MN1,NHEL(4),+1*IC(4),W(1,4))
-CALL FVICXX(W(1,3),W(1,1),GWN1X1,MX1,WX1,W(1,5))
-# Amplitude(s) for diagram number 1
-CALL IOVCXX(W(1,5),W(1,4),W(1,2),GWX1N1,AMP(1))
-CALL FVOXXX(W(1,4),W(1,1),GWN1X1,MX1,WX1,W(1,6))
-# Amplitude(s) for diagram number 2
-CALL IOVXXX(W(1,3),W(1,6),W(1,2),GWX1N1,AMP(2))""")
+CALL FVIXXX(W(1,3),W(1,1),GWX1N1,MX1,WX1,W(1,5))
+# Amplitude(s) for diagram number 1
+CALL IOVXXX(W(1,5),W(1,4),W(1,2),GWN1X1,AMP(1))
+CALL FVOCXX(W(1,4),W(1,1),GWX1N1,MX1,WX1,W(1,6))
+# Amplitude(s) for diagram number 2
+CALL IOVCXX(W(1,3),W(1,6),W(1,2),GWN1X1,AMP(2))""")
+
+    def test_switched_chargino_process(self):
+        """Test process e+ e- > x1+ x1- with inverted x1+/-
+        """
+
+        mypartlist = base_objects.ParticleList()
+        myinterlist = base_objects.InteractionList()
+
+        # A electron and positron
+        mypartlist.append(base_objects.Particle({'name':'e-',
+                      'antiname':'e+',
+                      'spin':2,
+                      'color':1,
+                      'mass':'zero',
+                      'width':'zero',
+                      'texname':'e^-',
+                      'antitexname':'e^+',
+                      'line':'straight',
+                      'charge':-1.,
+                      'pdg_code':11,
+                      'propagating':True,
+                      'is_part':True,
+                      'self_antipart':False}))
+        eminus = mypartlist[len(mypartlist) - 1]
+        eplus = copy.copy(eminus)
+        eplus.set('is_part', False)
+
+        # A photon
+        mypartlist.append(base_objects.Particle({'name':'a',
+                      'antiname':'a',
+                      'spin':3,
+                      'color':1,
+                      'mass':'zero',
+                      'width':'zero',
+                      'texname':'\gamma',
+                      'antitexname':'\gamma',
+                      'line':'wavy',
+                      'charge':0.,
+                      'pdg_code':22,
+                      'propagating':True,
+                      'is_part':True,
+                      'self_antipart':True}))
+        a = mypartlist[len(mypartlist) - 1]
+
+        # A sneutrino and its antiparticle
+        mypartlist.append(base_objects.Particle({'name':'sve',
+                      'antiname':'sve~',
+                      'spin':1,
+                      'color':1,
+                      'mass':'Msve',
+                      'width':'Wsve',
+                      'texname':'ve',
+                      'antitexname':'\tilde ve',
+                      'line':'dashed',
+                      'charge':0.,
+                      'pdg_code':1000012,
+                      'propagating':True,
+                      'is_part':True,
+                      'self_antipart':False}))
+        sve = mypartlist[len(mypartlist) - 1]
+        svebar = copy.copy(sve)
+        svebar.set('is_part', False)
+
+        # chargino+/-
+        mypartlist.append(base_objects.Particle({'name':'x1-',
+                      'antiname':'x1+',
+                      'spin':2,
+                      'color':1,
+                      'mass':'MX1',
+                      'width':'WX1',
+                      'texname':'x1-',
+                      'antitexname':'x1+',
+                      'line':'straight',
+                      'charge':-1.,
+                      'pdg_code':1000024,
+                      'propagating':True,
+                      'is_part':True,
+                      'self_antipart':False}))
+        x1minus = mypartlist[len(mypartlist) - 1]
+        x1plus = copy.copy(x1minus)
+        x1plus.set('is_part', False)
+
+        # Coupling of e to gamma
+        myinterlist.append(base_objects.Interaction({
+                      'id': 1,
+                      'particles': base_objects.ParticleList(\
+                                            [eplus, \
+                                             eminus, \
+                                             a]),
+                      'color': [],
+                      'lorentz':['FFV1'],
+                      'couplings':{(0, 0):'GAEE'},
+                      'orders':{'QED':1}}))
+
+        # Coupling of x1+/- to gamma
+        myinterlist.append(base_objects.Interaction({
+                      'id': 2,
+                      'particles': base_objects.ParticleList(\
+                                            [x1minus, \
+                                             x1plus, \
+                                             a]),
+                      'color': [],
+                      'lorentz':['FFV2'],
+                      'couplings':{(0, 0):'GAXX'},
+                      'orders':{'QED':1}}))
+
+        # Coupling of x1 to e and sve
+        myinterlist.append(base_objects.Interaction({
+                      'id': 3,
+                      'particles': base_objects.ParticleList(\
+                                            [eplus, \
+                                             x1minus, \
+                                             sve]),
+                      'color': [],
+                      'lorentz':['FFS1'],
+                      'couplings':{(0, 0):'GEXV'},
+                      'orders':{'QED':1}}))
+
+        myinterlist.append(base_objects.Interaction({
+                      'id': 4,
+                      'particles': base_objects.ParticleList(\
+                                            [eminus, \
+                                             x1plus, \
+                                             svebar]),
+                      'color': [],
+                      'lorentz':['FFS1'],
+                      'couplings':{(0, 0):'GEXV'},
+                      'orders':{'QED':1}}))
+
+        mymodel = base_objects.Model()
+        mymodel.set('particles', mypartlist)
+        mymodel.set('interactions', myinterlist)
+
+        myleglist = base_objects.LegList()
+
+        myleglist.append(base_objects.Leg({'id':-11,
+                                         'state':False}))
+        myleglist.append(base_objects.Leg({'id':11,
+                                         'state':False}))
+        myleglist.append(base_objects.Leg({'id':-1000024,
+                                         'state':True}))
+        myleglist.append(base_objects.Leg({'id':1000024,
+                                         'state':True}))
+
+        myproc = base_objects.Process({'legs':myleglist,
+                                           'model':mymodel})
+        myamplitude = diagram_generation.Amplitude({'process': myproc})
+
+        self.assertEqual(len(myamplitude.get('diagrams')), 2)
+
+        me = helas_objects.HelasMatrixElement(myamplitude,
+                                              gen_color=False)
+
+        myfortranmodel = helas_call_writers.FortranUFOHelasCallWriter(mymodel)
+
+        self.assertEqual("\n".join(myfortranmodel.get_matrix_element_calls(me)),
+        """CALL OXXXXX(P(0,1),zero,NHEL(1),-1*IC(1),W(1,1))
+CALL IXXXXX(P(0,2),zero,NHEL(2),+1*IC(2),W(1,2))
+CALL IXXXXX(P(0,3),MX1,NHEL(3),-1*IC(3),W(1,3))
+CALL OXXXXX(P(0,4),MX1,NHEL(4),+1*IC(4),W(1,4))
+CALL FFV1_3(W(1,2),W(1,1),GAEE,zero, zero, W(1,5))
+# Amplitude(s) for diagram number 1
+CALL FFV2C1_0(W(1,3),W(1,4),W(1,5),GAXX,AMP(1))
+CALL FFS1C1_3(W(1,3),W(1,1),GEXV,Msve, Wsve, W(1,6))
+# Amplitude(s) for diagram number 2
+CALL FFS1_0(W(1,2),W(1,4),W(1,6),GEXV,AMP(2))""")
 
 
     def test_export_majorana_decay_chain(self):
@@ -6724,8 +6890,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 7,
                       'particles': base_objects.ParticleList(\
-                                            [eminus, \
-                                             eplus, \
+                                            [eplus, \
+                                             eminus, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -8198,8 +8364,6 @@
 
         result = myfortranmodel.get_matrix_element_calls(matrix_element)
 
-        #print "\n".join(result)
-
         goal = """CALL IXXXXX(P(0,1),zero,NHEL(1),+1*IC(1),W(1,1))
 CALL IXXXXX(P(0,2),zero,NHEL(2),+1*IC(2),W(1,2))
 CALL OXXXXX(P(0,3),mn2,NHEL(3),+1*IC(3),W(1,3))

=== modified file 'tests/unit_tests/iolibs/test_helas_call_writers.py'
--- tests/unit_tests/iolibs/test_helas_call_writers.py	2011-05-16 19:41:08 +0000
+++ tests/unit_tests/iolibs/test_helas_call_writers.py	2012-01-26 10:43:23 +0000
@@ -104,14 +104,14 @@
         antid.set('is_part', False)
 
         # A electron and positron
-        mypartlist.append(base_objects.Particle({'name':'e+',
-                      'antiname':'e-',
+        mypartlist.append(base_objects.Particle({'name':'e-',
+                      'antiname':'e+',
                       'spin':2,
                       'color':1,
                       'mass':'me',
                       'width':'zero',
-                      'texname':'e^+',
-                      'antitexname':'e^-',
+                      'texname':'e^-',
+                      'antitexname':'e^+',
                       'line':'straight',
                       'charge':-1.,
                       'pdg_code':11,
@@ -251,8 +251,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 3,
                       'particles': base_objects.ParticleList(\
-                                            [u, \
-                                             antiu, \
+                                            [antiu, \
+                                             u, \
                                              g]),
                       'color': [],
                       'lorentz':[''],
@@ -262,8 +262,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 4,
                       'particles': base_objects.ParticleList(\
-                                            [d, \
-                                             antid, \
+                                            [antid, \
+                                             d, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -273,8 +273,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 10,
                       'particles': base_objects.ParticleList(\
-                                            [d, \
-                                             antid, \
+                                            [antid, \
+                                             d, \
                                              g]),
                       'color': [],
                       'lorentz':[''],
@@ -284,8 +284,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 11,
                       'particles': base_objects.ParticleList(\
-                                            [u, \
-                                             antiu, \
+                                            [antiu, \
+                                             u, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -321,8 +321,8 @@
         myinterlist.append(base_objects.Interaction({
                       'id': 7,
                       'particles': base_objects.ParticleList(\
-                                            [eminus, \
-                                             eplus, \
+                                            [eplus, \
+                                             eminus, \
                                              a]),
                       'color': [],
                       'lorentz':[''],
@@ -543,9 +543,9 @@
         """Test automatic generation of wavefunction and amplitude calls"""
 
         goal = [ \
-            'CALL IXXXXX(P(0,1),me,NHEL(1),+1*IC(1),W(1,1))',
-            'CALL OXXXXX(P(0,2),me,NHEL(2),-1*IC(2),W(1,2))',
-            'CALL VXXXXX(P(0,3),zero,NHEL(3),-1*IC(3),W(1,3))',
+            'CALL IXXXXX(P(0,1),me,NHEL(1),-1*IC(1),W(1,1))',
+            'CALL OXXXXX(P(0,2),me,NHEL(2),+1*IC(2),W(1,2))',
+            'CALL VXXXXX(P(0,3),zero,NHEL(3),+1*IC(3),W(1,3))',
             'CALL FVOXXX(W(1,2),W(1,3),MGVX12,me,zero,W(1,1))',
             'CALL FVIXXX(W(1,1),W(1,3),MGVX12,me,zero,W(1,2))',
             'CALL JIOXXX(W(1,1),W(1,2),MGVX12,zero,zero,W(1,3))',
@@ -569,15 +569,15 @@
 
         myleglist = base_objects.LegList()
 
+        myleglist.append(base_objects.Leg({'id':-11,
+                                           'number': 1,
+                                           'state':True}))
         myleglist.append(base_objects.Leg({'id':11,
-                                           'number': 1,
-                                           'state':False}))
-        myleglist.append(base_objects.Leg({'id':-11,
                                            'number': 2,
-                                         'state':False}))
+                                         'state':True}))
         myleglist.append(base_objects.Leg({'id':22,
                                            'number': 3,
-                                         'state':False}))
+                                         'state':True}))
 
         wfs = helas_objects.HelasWavefunctionList(\
             [ helas_objects.HelasWavefunction(leg, 7,