Code review comment for lp:~maddevelopers/mg5amcnlo/3.0.4-qcdonly

Revision history for this message
marco zaro (marco-zaro) wrote :

Hi Olivier,
the changes to the code look fine.
As I wrote you on skype, I would warn the user if one has nlo_mixed_expansion = False but the LO diagrams have more than one coupling combination. While this may be OK in some cases (EFT), it may be completely wrong in other (I guess for these cases one has check-poles failing, etc..)

Thanks a lot!

Cheers,

Marco

review: Approve

« Back to merge proposal