Merge lp:~maddevelopers/mg5amcnlo/1.2.1 into lp:~madteam/mg5amcnlo/trunk

Proposed by Olivier Mattelaer
Status: Merged
Merged at revision: 131
Proposed branch: lp:~maddevelopers/mg5amcnlo/1.2.1
Merge into: lp:~madteam/mg5amcnlo/trunk
Diff against target: 70 lines (+26/-7) (has conflicts)
2 files modified
Template/SubProcesses/myamp.f (+13/-7)
UpdateNotes.txt (+13/-0)
Text conflict in UpdateNotes.txt
To merge this branch: bzr merge lp:~maddevelopers/mg5amcnlo/1.2.1
Reviewer Review Type Date Requested Status
Johan Alwall (community) Approve
Review via email: mp+60294@code.launchpad.net

Description of the change

Few fixes and minor improvment (see Updates Notes)
So Johan, when you are ready with your fix, you can merge those one too.

To post a comment you must log in.
lp:~maddevelopers/mg5amcnlo/1.2.1 updated
130. By Johan Alwall

Fixed problem when s-channel mass > s_tot

Revision history for this message
Johan Alwall (johan-alwall) wrote :

Excellent! I have no complaints or changes :-)

I just fixed the problem that Gauthier found, so you can merge at any time.

Johan

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'Template/SubProcesses/myamp.f'
2--- Template/SubProcesses/myamp.f 2011-04-21 15:56:29 +0000
3+++ Template/SubProcesses/myamp.f 2011-05-08 05:38:24 +0000
4@@ -443,16 +443,15 @@
5 c JA 4/1/2011 Set grid in case there is no BW (radiation process)
6 if (swidth(-i) .eq. 0d0)then
7 a=pmass(i,iconfig)**2/stot
8-c Ensure that xo > a
9- xo = max(xm(i)**2/stot,a*1.01)
10+ xo = xm(i)**2/stot
11 call setgrid(-i,xo,a,1)
12 endif
13 else !1/x^pow
14 a=pmass(i,iconfig)**2/stot
15-c JA 4/1/2011 Ensure xo > a, always set grid
16- xo = max(xm(i)**2/stot,a*1.01)
17+c JA 4/1/2011 always set grid
18+ xo = xm(i)**2/stot
19 c if (pwidth(i, iconfig) .eq. 0d0.or.iden_part(i).gt.0) then
20- call setgrid(-i,xo,a,1)
21+ call setgrid(-i,xo,a,1)
22 c else
23 c write(*,*) 'Using flat grid for BW',i,nbw,
24 c $ pmass(i,iconfig)
25@@ -499,13 +498,20 @@
26
27 c write(*,*) 'Enter minimum for ',-i, xo
28 c read(*,*) xo
29-
30 if (i .ne. -1 .or. .true.) call setgrid(-i,xo,a,1)
31 endif
32 enddo
33 if (abs(lpp(1)) .eq. 1 .or. abs(lpp(2)) .eq. 1) then
34 c Set minimum based on: 1) required energy 2) resonances 3) 1/10000 of sqrt(s)
35- xo = max(max(etot**2, forced_mass**2)/stot,1e-8)
36+ if(forced_mass**2.lt.stot) then
37+ xo = max(max(etot**2, forced_mass**2)/stot,1d-8)
38+ else
39+ xo = max(etot**2/stot,1d-8)
40+ endif
41+ if (xo.eq.1d-8) then
42+ write(*,*) 'Warning: No minimum found for integration'
43+ write(*,*) ' Setting minimum to 1e-8*stot'
44+ endif
45 i = 3*(nexternal-2) - 4 + 1
46 c-----------------------
47 c tjs 4/29/2008 use analytic transform for s-hat
48
49=== modified file 'UpdateNotes.txt'
50--- UpdateNotes.txt 2011-05-08 00:29:32 +0000
51+++ UpdateNotes.txt 2011-05-08 05:38:24 +0000
52@@ -1,5 +1,18 @@
53 Update notes for MadGraph 5 (in reverse time order)
54
55+<<<<<<< TREE
56+=======
57+
58+1.2.1 (07/05/11) OM: reduce the quantity of RAM use by matrix.f
59+ OM: support speed of psyco if this python module is installed
60+ OM: fix a minor bug in the model parsing
61+ OM: add the check of valid model.pkl also for v4 model
62+ OM: add a check that UpdatesNotes is up-to-date when
63+ making a release
64+ JA: Fixed problem in phase space generation for
65+ s-channel mass > s_tot
66+
67+>>>>>>> MERGE-SOURCE
68 1.2.0 (05/05/11): OM: minor fixes on check charge conjugation
69 OM: add a check on the path for the validity of the model.pkl
70 JA: Fixed problem with combine_runs on certain compilers

Subscribers

People subscribed via source and target branches