Merge lp:~macslow/unity8/icon-clipping-fix-1378417 into lp:unity8

Proposed by Mirco Müller
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 1422
Merged at revision: 1439
Proposed branch: lp:~macslow/unity8/icon-clipping-fix-1378417
Merge into: lp:unity8
Diff against target: 11 lines (+1/-1)
1 file modified
qml/Notifications/ShapedIcon.qml (+1/-1)
To merge this branch: bzr merge lp:~macslow/unity8/icon-clipping-fix-1378417
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Andrea Cimitan (community) Approve
Review via email: mp+241097@code.launchpad.net

Commit message

Make sure non-square icons are not cropped.

Description of the change

Make sure non-square icons are not cropped.

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Not applicable.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes
 * Did CI run pass? If not, please explain why.
autopilot
 * Did you make sure that the branch does not contain spurious tags?
Yes

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Notifications/ShapedIcon.qml'
2--- qml/Notifications/ShapedIcon.qml 2013-11-20 15:44:29 +0000
3+++ qml/Notifications/ShapedIcon.qml 2014-11-07 15:41:14 +0000
4@@ -35,6 +35,6 @@
5 anchors.fill: parent
6 visible: !shaped
7 source: fileSource
8- fillMode: Image.PreserveAspectCrop
9+ fillMode: Image.PreserveAspectFit
10 }
11 }

Subscribers

People subscribed via source and target branches