Merge lp:~macslow/unity8/fix-1346867 into lp:unity8

[Mirco Müller]

Make sure the TextField of a snap-decision notification has the active focus upon creation, thus the osk shows up right away.

Make sure the TextField of a snap-decision notification has the active focus upon creation, thus the osk shows up right away.

* Are there any related MPs required for this MP to build/function as expected? Please list.
No.

* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

* Did you make sure that your branch does not contain spurious tags?
Yes.

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Not applicable.

* If you changed the UI, has there been a design review?
Will do in silo.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1067
http://jenkins.qa.ubuntu.com/job/unity8-ci/3527/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2308
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/529
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/621
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/621
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/621/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/621
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2496
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3517
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3517/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10217

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3527/rebuild

review: Needs Fixing (continuous-integration)

[Michael Zanetti (mzanetti)]

I'd like to test this with QtCompositor. We're doing focus stuff there too. Ok to wait for QtComp to land before merging this?

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1067
http://jenkins.qa.ubuntu.com/job/unity8-ci/3618/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2544
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/620
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/712
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/712
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/712/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/712
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/2691
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3787
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/3787/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10488

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3618/rebuild

review: Needs Fixing (continuous-integration)

[Michael Terry (mterry)]

 * Did you perform an exploratory manual test run of the code change and any related functionality?
 - Yup, worked great

 * Did CI run pass? If not, please explain why.
 - I didn't get them locally, but they are in a related area of code. Mirco, do you have a guess why they happen?

review: Needs Information

[Michael Terry (mterry)]

"I don't get the autopilot test failures locally" I meant

[Michał Sawicz (saviq)]

Kicked CI on this again.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1067
http://jenkins.qa.ubuntu.com/job/unity8-ci/3748/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/2986
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/750
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/842
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/842
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/842/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/842
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3038
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4229
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4229/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/10939

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3748/rebuild

review: Needs Fixing (continuous-integration)

[Michael Terry (mterry)]

OK, autopilot failures are gone. qmluitests failures are unrelated.

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1067
http://jenkins.qa.ubuntu.com/job/unity8-ci/3769/
Executed test runs:
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3064
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/771
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/863
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/863
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/863/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/863
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3104
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4307
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4307/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11036

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3769/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'qml/Notifications/NotificationMenuItemFactory.qml'
--- qml/Notifications/NotificationMenuItemFactory.qml	2014-07-04 10:08:26 +0000
+++ qml/Notifications/NotificationMenuItemFactory.qml	2014-07-22 12:18:51 +0000
@@ -76,6 +76,9 @@
                 }
                 echoMode: checkBox.checked ? TextInput.Normal : TextInput.Password
                 height: units.gu(5)
+                Component.onCompleted: {
+                    forceActiveFocus();
+                }
                 onTextChanged: {
                     menuModel.changeState(menuIndex, text);
                 }