Merge lp:~macslow/unity8/extended-snap-decision-pw-checkmark into lp:unity8

[Mirco Müller]

Added checkbox for toggling between echo-modes of password-entryfields in ext. snap-decisions.

Added checkbox for toggling between echo-modes of password-entryfields in ext. snap-decisions.

[Mirco Müller (macslow)]

I'm still waiting on Design-feedback, as I've not seen any mockups for this interface-change yet.

[Mirco Müller (macslow)]

Here's a screencast for your convenience http://www.youtube.com/watch?v=cTwHcesdIaM to see what's it about and what the layout currently looks like.

[Mirco Müller (macslow)]

Design (mpt) is ok with the current state of this, so I'll flip the switch to needs-review.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:482
http://jenkins.qa.ubuntu.com/job/unity8-ci/1555/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/371
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/359
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/105
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/79
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/79
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/79/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/79
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/347
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/371
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/371/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/359
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/359/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/2941
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3025
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/964
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/961

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1555/rebuild

review: Approve (continuous-integration)

[Albert Astals Cid (aacid)]

the text needs i18n and you need to also update the pot file (make pot_file)

review: Needs Fixing

[Mirco Müller (macslow)]

Will add that right away.

[lp:~macslow/unity8/extended-snap-decision-pw-checkmark]

483. By Mirco Müller on 2013-11-05

Made "Show password"-message translatable and updated .pot file.

[Mirco Müller (macslow)]

BTW, I used the script unity8/po/update-unity-pot as there's no "pot_file" make-target.

[Albert Astals Cid (aacid)]

Looks good :-)

review: Approve

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:483
http://jenkins.qa.ubuntu.com/job/unity8-ci/1582/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty/460
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-trusty-touch/448
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-trusty/143
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-amd64-ci/106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/106
        deb: http://jenkins.qa.ubuntu.com/job/unity8-trusty-armhf-ci/106/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-trusty-i386-ci/106
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-trusty/423
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/460
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-amd64/460/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/448
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-trusty-armhf/448/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/3103
    SUCCESS: http://10.97.0.26:8080/job/touch-flash-device/1073

Click here to trigger a rebuild:
http://10.97.0.26:8080/job/unity8-ci/1582/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

review: Approve (continuous-integration)

=== modified file 'Notifications/NotificationMenuItemFactory.qml'
--- Notifications/NotificationMenuItemFactory.qml	2013-10-09 18:24:16 +0000
+++ Notifications/NotificationMenuItemFactory.qml	2013-11-05 16:55:28 +0000
@@ -54,7 +54,8 @@
 
             Component.onCompleted: {
                 menuModel.loadExtendedAttributes(menuIndex, {"x-echo-mode-password": "bool"});
-                textfield.echoMode = menuData.ext.xEchoModePassword ? TextInput.Password : TextInput.Normal
+                checkBox.checked = menuData.ext.xEchoModePassword ? false : true
+                checkBoxRow.visible = menuData.ext.xEchoModePassword
             }
 
             Label {
@@ -65,11 +66,29 @@
                 id: textfield
 
                 anchors.left: parent.left; anchors.right: parent.right
+                echoMode: checkBox.checked ? TextInput.Normal : TextInput.Password
                 height: units.gu(5)
                 onTextChanged: {
                     menuModel.changeState(menuIndex, text);
                 }
             }
+
+            Row {
+                id: checkBoxRow
+
+                spacing: units.gu(.5)
+
+                CheckBox {
+                    id: checkBox
+
+                    checked: false
+                }
+
+                Label {
+                    anchors.verticalCenter: checkBox.verticalCenter
+                    text: i18n.tr("Show password")
+                }
+            }
         }
     }
 

=== modified file 'po/unity8.pot'
--- po/unity8.pot	2013-10-11 10:12:35 +0000
+++ po/unity8.pot	2013-11-05 16:55:28 +0000
@@ -8,7 +8,7 @@
 msgstr ""
 "Project-Id-Version: unity8\n"
 "Report-Msgid-Bugs-To: \n"
-"POT-Creation-Date: 2013-10-11 12:12+0200\n"
+"POT-Creation-Date: 2013-11-05 17:53+0100\n"
 "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
 "Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
 "Language-Team: LANGUAGE <[e-mail]>\n"
@@ -205,11 +205,15 @@
 msgid "Speaking..."
 msgstr ""
 
+#: Notifications/NotificationMenuItemFactory.qml:89
+msgid "Show password"
+msgstr ""
+
 #: Panel/SearchIndicator.qml:27
 msgid "Search"
 msgstr ""
 
-#: plugins/Unity/scope.cpp:398
+#: plugins/Unity/scope.cpp:408
 msgid "Sorry, there is nothing that matches your search."
 msgstr ""