Code review comment for lp:~macslow/unity/unity.fix-863230

John Lea (johnlea) wrote :

If you watch the Chromium icon in the video, it's tinting is changing at a time when it should remain static. Look at the Chromium icon at 0:06 in the video, this is the correct state. Now if you scrub back to 0:04, you will see the tinting on the Chromium icon has changed slightly, even though it is not a valid drop target.

Requested fix in order for this change to be complete and ready to land: When a user starts dragging a icon in the Dash, the tinting of Launcher icons that are not valid drop targets should not change in *any* way, even temporally.

review: Needs Fixing (design)

« Back to merge proposal