Merge lp:~macslow/unity/unity.fix-863230 into lp:unity
Status: | Merged |
---|---|
Approved by: | Didier Roche-Tolomelli |
Approved revision: | no longer in the source branch. |
Merged at revision: | 2104 |
Proposed branch: | lp:~macslow/unity/unity.fix-863230 |
Merge into: | lp:unity |
Diff against target: |
42 lines (+20/-0) 2 files modified
manual-tests/DragDropDashLauncher.txt (+6/-0) plugins/unityshell/src/Launcher.cpp (+14/-0) |
To merge this branch: | bzr merge lp:~macslow/unity/unity.fix-863230 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
John Lea (community) | design | Needs Fixing | |
Tim Penhey (community) | Approve | ||
Review via email: mp+93265@code.launchpad.net |
Description of the change
Trying to understand how and where changes to an icons alpha- and saturation-value are taking place is material to get insane. By now I've spent many many many hours trying to get behind what's going on. I can't say I fully grasp
the intricate ways of icons opacity and saturation in class Launcher.
As far as I can tell, there are four valid "cases" for the launcher icons in terms of alpha and saturation. To make it easier for you to follow, have a look at this table:
-------
| dash open | 0.5 | 0.0 |
| dash closed | 1.0 | 1.0 |
| drop-target (dragging & dash open) | 1.0 | 1.0 |
| no drop-target (dragging & dash open) | 0.5 | 0.0 |
-------
So alpha should never be outside [0.5 .. 1.0] and saturation should never be outside [0.0 .. 1.0]. From my investigation it is sufficient to protect only against the lower threshold, where alpha needs to be 0.5 and saturation 0.0
without fix:
http://
with fix:
http://
If anybody ever causes this to regress, I'll ... !
Screw LP text-formatting of merge-proposal messages!