Merge lp:~macslow/unity-lens-music/unity-lens-music.fix-841902 into lp:unity-lens-music

Proposed by Mirco Müller
Status: Merged
Approved by: Mikkel Kamstrup Erlandsen
Approved revision: 65
Merged at revision: 67
Proposed branch: lp:~macslow/unity-lens-music/unity-lens-music.fix-841902
Merge into: lp:unity-lens-music
Diff against target: 94 lines (+9/-9)
5 files modified
src/banshee-filter-parser-genre.vala (+2/-2)
src/daemon.vala (+1/-1)
src/filter-parser-genre.vala (+3/-3)
src/musicstore-filter-parser-genre.vala (+2/-2)
src/simple-scope.vala (+1/-1)
To merge this branch: bzr merge lp:~macslow/unity-lens-music/unity-lens-music.fix-841902
Reviewer Review Type Date Requested Status
Mikkel Kamstrup Erlandsen (community) Approve
Review via email: mp+88987@code.launchpad.net

Description of the change

Resubmitting to make sure it's meant to go into trunk. I wonder what made LP think I wanted to merge it to anything different than trunk initially.

The second part of the fix for LP: #841902.

To post a comment you must log in.
Revision history for this message
Mikkel Kamstrup Erlandsen (kamstrup) wrote :

Looks good (still ;-))

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/banshee-filter-parser-genre.vala'
2--- src/banshee-filter-parser-genre.vala 2011-09-14 18:33:52 +0000
3+++ src/banshee-filter-parser-genre.vala 2012-01-18 08:14:25 +0000
4@@ -26,7 +26,7 @@
5
6 public BansheeGenreFilterParser (GenreFilterParser parser)
7 {
8- base (parser.filter as CheckOptionFilter);
9+ base (parser.filter as CheckOptionFilterCompact);
10 }
11
12 public override string parse ()
13@@ -55,4 +55,4 @@
14 return builder.str;
15 }
16 }
17-}
18\ No newline at end of file
19+}
20
21=== modified file 'src/daemon.vala'
22--- src/daemon.vala 2011-09-22 00:12:38 +0000
23+++ src/daemon.vala 2012-01-18 08:14:25 +0000
24@@ -71,7 +71,7 @@
25
26 /* Genre filter */
27 {
28- var filter = new CheckOptionFilter ("genre", _("Genre"));
29+ var filter = new CheckOptionFilterCompact ("genre", _("Genre"));
30 filter.sort_type = OptionsFilter.SortType.DISPLAY_NAME;
31
32 filter.add_option (Genre.BLUES_ID, _("Blues"));
33
34=== modified file 'src/filter-parser-genre.vala'
35--- src/filter-parser-genre.vala 2011-09-28 18:44:11 +0000
36+++ src/filter-parser-genre.vala 2012-01-18 08:14:25 +0000
37@@ -23,7 +23,7 @@
38
39 public class GenreFilterParser : FilterParser
40 {
41- public GenreFilterParser (CheckOptionFilter filter)
42+ public GenreFilterParser (CheckOptionFilterCompact filter)
43 {
44 base (filter);
45 map = new Genre ();
46@@ -39,7 +39,7 @@
47
48 protected List<FilterOption> get_all_selected_genres ()
49 {
50- unowned List<FilterOption> options = (filter as CheckOptionFilter).options;
51+ unowned List<FilterOption> options = (filter as CheckOptionFilterCompact).options;
52 var active = new List<FilterOption> ();
53
54 foreach (FilterOption option in options)
55@@ -51,4 +51,4 @@
56 return active;
57 }
58 }
59-}
60\ No newline at end of file
61+}
62
63=== modified file 'src/musicstore-filter-parser-genre.vala'
64--- src/musicstore-filter-parser-genre.vala 2011-09-28 18:44:11 +0000
65+++ src/musicstore-filter-parser-genre.vala 2012-01-18 08:14:25 +0000
66@@ -26,7 +26,7 @@
67
68 public MusicStoreGenreFilterParser (GenreFilterParser parser)
69 {
70- base (parser.filter as CheckOptionFilter);
71+ base (parser.filter as CheckOptionFilterCompact);
72 }
73
74 public override string parse ()
75@@ -49,4 +49,4 @@
76 return builder.str;
77 }
78 }
79-}
80\ No newline at end of file
81+}
82
83=== modified file 'src/simple-scope.vala'
84--- src/simple-scope.vala 2011-12-07 11:15:45 +0000
85+++ src/simple-scope.vala 2012-01-18 08:14:25 +0000
86@@ -99,7 +99,7 @@
87 List<FilterParser> filters = new List<FilterParser> ();
88 Filter filter = scope.get_filter ("genre");
89 if (filter.filtering)
90- filters.append (new GenreFilterParser (filter as CheckOptionFilter));
91+ filters.append (new GenreFilterParser (filter as CheckOptionFilterCompact));
92
93 filter = scope.get_filter ("decade");
94 if (filter.filtering)

Subscribers

People subscribed via source and target branches

to all changes: