Merge lp:~macslow/unity-lens-music/unity-lens-music.fix-841902 into lp:unity-lens-music/0.3
Proposed by
Mirco Müller
Status: | Rejected |
---|---|
Rejected by: | Michal Hruby |
Proposed branch: | lp:~macslow/unity-lens-music/unity-lens-music.fix-841902 |
Merge into: | lp:unity-lens-music/0.3 |
Diff against target: |
94 lines (+9/-9) 5 files modified
src/banshee-filter-parser-genre.vala (+2/-2) src/daemon.vala (+1/-1) src/filter-parser-genre.vala (+3/-3) src/musicstore-filter-parser-genre.vala (+2/-2) src/simple-scope.vala (+1/-1) |
To merge this branch: | bzr merge lp:~macslow/unity-lens-music/unity-lens-music.fix-841902 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Mikkel Kamstrup Erlandsen (community) | Approve | ||
Review via email: mp+88032@code.launchpad.net |
Description of the change
The second part of the fix for LP: #841902.
To post a comment you must log in.
Unmerged revisions
- 65. By Mirco Müller
-
Use the new/correct name for the new CheckOptions filter
- 64. By Mirco Müller
-
Using the new (temporary name) CheckFilterOption2 to support a 3-column layout... attempt to fix LP: #841902
28 - var filter = new CheckOptionFilter ("genre", _("Genre")); erCompact ("genre", _("Genre"));
29 + var filter = new CheckOptionFilt
Technically, I think this is the only needed change right? The other casts where still valid since CheckOptionFilt erCompact is a subclass of CheckOptionFilter, correct?
In any case, this is mostly a personal- taste-issue, so I wont object. Let's get the stuff in!