Code review comment for lp:~macslow/notify-osd/notify-osd.fix-1092905

Revision history for this message
Sebastien Bacher (seb128) wrote :

Thanks

> !g_strcmp0("Unity", g_environ_getenv (g_get_environ (), "XDG_CURRENT_DESKTOP")))

that seems a bit complicated, we usually use "!g_strcmp0 (g_getenv ("XDG_CURRENT_DESKTOP"), "Unity")" (one less call)

I'm also not sure to understand the y computation ... do we have somebody knowing that code a bit that could review that? (I still don't understand why we can't just use the same computation than the no-focus-follow case since that one is correct, the panel size doesn't change between monitors)

review: Needs Fixing

« Back to merge proposal