Merge lp:~mabac/svammel/add-patterns-for-tags into lp:svammel

[Mattias Backman]

Hi,

This branch just adds some patterns for setting bug tags depending on contents of the build log. Perhaps there should be some more infrastructure around it where to put more regexps, but for now I think simple is better. If this gets messy I'll have to think of a better solution then.

Thanks,

Mattias

[James Westby (james-w)]

Hi,

Can we compile the regexes outside of the loop and so save on repeating those
expensive operations on every build log?

Thanks,

James

review: Needs Fixing

[Mattias Backman (mabac)]

> Can we compile the regexes outside of the loop and so save on repeating those
> expensive operations on every build log?

Sure we can. I'm on it.

Thanks,

Mattias

[Mattias Backman (mabac)]

Hi,

I resubmitted this mp to be able to set lp:~mabac/svammel/move-regexmatching-to-utils as pre-requisite.

Thanks,

Mattias

[James Westby (james-w)]

review: Approve

=== modified file 'data_parsing.py'
--- data_parsing.py	2011-04-15 07:40:10 +0000
+++ data_parsing.py	2011-04-15 10:27:23 +0000
@@ -23,7 +23,11 @@
 from launchpadlib.uris import *
 import apt_pkg
 import logging
+import re
 
+from matching import (
+    RegexpMatcher,
+    )
 from config import (
     get_base_url,
     get_base_api_url,
@@ -42,6 +46,7 @@
 FAILED_BUILD_STATE = 'Failed to build'
 SUCCESS_BUILD_STATE = 'Successfully built'
 logger = logging.getLogger(LOGGER_NAME)
+matchers = None
 
 
 class InvalidArchiveError(Exception):
@@ -52,13 +57,39 @@
         return repr(self.value)
 
 
+def init_matchers():
+    global matchers
+    matchers = []
+
+    logger.debug('Creating pattern matchers for setting tags.')
+
+    # Add your patterns here as (pattern, tag) pairs.
+    regexps_and_tags = [
+        (r'fatal error: linux/videodev.h: No such file or directory', 'v4l'),
+        (r'is defined in DSO .*so try adding it to the linker command line', 'no-add-needed'),
+        (r'NoClassDefFoundError: org/apache/tools/ant/taskdefs/optional/TraXLiaison', 'ant'),
+        (r'internal compiler error', 'ice'),
+        (r'No rule to make target .*lib.*\.la., needed by .*lib.*\.la', 'multiarch'),
+        ]
+
+    for regexp, tag in regexps_and_tags:
+        matchers.append(RegexpMatcher(tag, regexp))
+
+
 def get_tags_for_fail(fail_data=''):
     """ Determine cause of failure and tag accordingly. """
 
     tags = []
     if fail_data != '':
         # Process build log contents to determine extra tags
-        pass
+        if matchers is None:
+            init_matchers()
+
+        for matcher in matchers:
+            if matcher.match(fail_data):
+                tags.append(matcher.get_name())
+
+    logger.debug('Extra bug tags %s.', tags)
     return tags
 
 

=== modified file 'tests/test_fail_filer.py'
--- tests/test_fail_filer.py	2011-04-14 12:28:23 +0000
+++ tests/test_fail_filer.py	2011-04-15 10:27:23 +0000
@@ -69,6 +69,10 @@
         tags = get_tags_for_fail("This will never trigger matcher.")
         self.assertEquals([], tags)
 
+    def test_ice_match_sets_extra_tag(self):
+        tags = get_tags_for_fail("internal compiler error")
+        self.assertIn('ice', tags)
+
 
 class TestFilter(TestCaseWithFixtures):