Merge lp:~mabac/launchpad/login-raises-non-string into lp:launchpad

[Mattias Backman]

[r=jcsackett,rharding][no-qa] Raise ValueError if the email parameter to login() is not a string. Branch by Mattias Backman.

Hi,

This branch adds a check to login() in lib/lp/testing/_login.py so that it raises an error if the email parameter is not a string.

Thanks,

Mattias

[Richard Harding (rharding)]

In checking the method the only possible options are either an email address or the lp.testing.ANONYMOUS which is a string as well.

I asked in IRC the driving idea behind the change and your explanation of clearing up a potential confusing error message seems potentially helpful in debugging the failing test driven from passing a non-email string to the method.

As noted in irc by salgado, basestring would be a much better comparison since often this will be a unicode string and not a strict str. Please update that.

review: Needs Fixing (code*)

[Richard Harding (rharding)]

Changes look good to me.

review: Approve (code*)

[j.c.sackett (jcsackett)]

I have nothing to add, thank you for updating to using basestring.

review: Approve

=== modified file 'lib/lp/testing/_login.py'
--- lib/lp/testing/_login.py	2012-01-01 02:58:52 +0000
+++ lib/lp/testing/_login.py	2012-02-02 14:19:27 +0000
@@ -69,6 +69,8 @@
     setPrincipal(), otherwise it must allow setting its principal attribute.
     """
 
+    if not isinstance(email, basestring):
+        raise ValueError("Expected email parameter to be a string.")
     participation = _test_login_impl(participation)
     setupInteractionByEmail(email, participation)