Merge lp:~mabac/launchpad-work-items-tracker/visible-lane-selector into lp:~linaro-automation/launchpad-work-items-tracker/linaro

Proposed by Mattias Backman
Status: Merged
Merged at revision: 317
Proposed branch: lp:~mabac/launchpad-work-items-tracker/visible-lane-selector
Merge into: lp:~linaro-automation/launchpad-work-items-tracker/linaro
Diff against target: 33 lines (+9/-7)
1 file modified
templates/roadmap_lane.html (+9/-7)
To merge this branch: bzr merge lp:~mabac/launchpad-work-items-tracker/visible-lane-selector
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) Approve
Christian Reis user experience Pending
Review via email: mp+85095@code.launchpad.net

Description of the change

Hi,

This branch makes the roadmap Lane selector more visible as requested by Stephen. It will increase the text size, use a different colour and align it to the right.

Thanks,

Mattias

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

Looks good to me

 review approve

review: Approve
Revision history for this message
Mattias Backman (mabac) wrote :

Stephen:
But anyway, it looks a bit strange to have the calendar quarter to select
now justified beyond the right of the table. How about moving it level and
having it over 2 rows:
Select calendar quarter to view
2011Q4 (current)

311. By Mattias Backman

Make the table fill the entire width of the frame so that the lane selector and table are aligned.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'templates/roadmap_lane.html'
2--- templates/roadmap_lane.html 2011-12-12 09:17:20 +0000
3+++ templates/roadmap_lane.html 2011-12-14 16:06:49 +0000
4@@ -6,20 +6,22 @@
5 import report_tools
6 %>
7
8-Lane to view:
9+<%def name="title()">
10+Progress for ${lane_title}
11+</%def>
12+
13+<h1>${title()}</h1>
14+
15+<p style="text-align: right; color: green; font-size: 13pt">
16+Select calendar quarter to view:<br>
17 <select name="laneselect" onchange="window.location=this.value;">
18 % for lane in lanes:
19 <option value="${lane.name}.html"${' selected="selected"' if lane.name == lane_title else ''}>${lane.name}${' (current)' if lane.is_current else ''}</option>
20 % endfor
21 </select>
22
23-<%def name="title()">
24-Progress for ${lane_title}
25-</%def>
26-
27-<h1>${title()}</h1>
28 <p>
29-<table>
30+<table width="100%">
31 <thead><tr><th>Card</th><th>Status</th><th>Team</th><th>Priority</th><th>Blueprints</th><th>Health</th></tr></thead>
32 % for status in statuses:
33 % for card_dict in status['cards']:

Subscribers

People subscribed via source and target branches