Code review comment for lp:~mabac/launchpad-work-items-tracker/support-deferred-cards

Данило Шеган (danilo) wrote :

Looks good to me: to confirm my understanding, this basically only replaces use of 'task_status is None' when checking if a card needs to be collected by using either task_status['parent_id'] or task['task']['workflow_stage_id'] to check if a lane by that ID is collected instead using the new method lane_is_collected. All the rest is reindentation, afaics, so good to go.

(and oh my, this code does miss tests :)

review: Approve

« Back to merge proposal