~maas-committers/maas/+git/temporal:norbert/v1.22.x

Last commit made on 2023-11-22
Get this branch:
git clone -b norbert/v1.22.x https://git.launchpad.net/~maas-committers/maas/+git/temporal

Branch merges

Branch information

Name:
norbert/v1.22.x
Repository:
lp:~maas-committers/maas/+git/temporal

Recent commits

70c2edd... by Norbert Hu <email address hidden>

Include WorkflowID & RunID when initializing branch tokens (#5152)

<!-- Describe what has changed in this PR -->
**What changed?**

<!-- Tell your future self why have you made these changes -->
**Why?**

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**

a3be9ff... by Norbert Hu <email address hidden>

Propagate fork request raw branch token to persistence layer (#5151)

<!-- Describe what has changed in this PR -->
**What changed?**

<!-- Tell your future self why have you made these changes -->
**Why?**

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**

515df7d... by Norbert Hu <email address hidden>

Undeprecate branch info and deprecate branch token in history tree (#4852)

Aside from ref counting w.r.t. history branch ancestors, the history
tree table also serves as the data source for history scavenger to scan
over and check if specific history data are considered turds.

Both branch info and branch token have been double-written to since the
branch info field has been initially annotated as deprecated. No need to
perform backfill. This change continues to double write both branch info
and branch token. However, scavenger now uses the branch info to perform
the scan. The branch token double write is in case rollback is involved.
The double write will be removed after the next minor release.

<!-- Describe what has changed in this PR -->
**What changed?**

<!-- Tell your future self why have you made these changes -->
**Why?**

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**

db23e86... by Yimin Chen <email address hidden>

Add action metrics for schedule and updates (#5101)

<!-- Describe what has changed in this PR -->
**What changed?**
Add more action metrics for schedules and updates

<!-- Tell your future self why have you made these changes -->
**Why?**
Add more actions

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**
eye_balls

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No

37da275... by Rodrigo Zhou <email address hidden>

Allow list of keywords in dual visibility setting (#5065)

<!-- Describe what has changed in this PR -->
**What changed?**
Allow list of keywords in dual visibility setting

<!-- Tell your future self why have you made these changes -->
**Why?**
Let dual visibility with Elasticsearch work with list of keywords for
backwards compatibility.

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**
No. Any setting involving standard visibility will work as usual: custom
search attributes are just ignored and not persisted.

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**
No.

26114d7... by Roey Berman <email address hidden>

Hopefully avoid panic in DescribeWorkflowExecution (#5057)

**What changed?**

Clone suspected mutating fields after a returning from
DescribeWorkflowExecution.

**Why?**

Noticed panics in serialization of the
`DescribeWorkflowExecutionResponse` object.

**How did you test it?**

No tests added, assuming that normal test coverage is enough.
Haven't reproduced the issue, this is based on a hunch.

**Potential risks**

None that I can foresee.

**Is hotfix candidate?**

Yes.

ddf9799... by Rodrigo Zhou <email address hidden>

Bump server version to 1.22.2 (#5056)

<!-- Describe what has changed in this PR -->
**What changed?**
Bump server version to 1.22.2

<!-- Tell your future self why have you made these changes -->
**Why?**

<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
**How did you test it?**

<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
**Potential risks**

<!-- Is this PR a hotfix candidate or require that a notification be
sent to the broader community? (Yes/No) -->
**Is hotfix candidate?**

ef3b92b... by David Reiss <email address hidden>

Fix schedule workflow unit test (#5052)

**What changed?**
Fix unit tests on release branch

**Why?**
The tests assumed that the change to not track ALLOW_ALL workflows was
already active, but it's not on the release branch. So we just need
mocks for WatchWorkflow.

**How did you test it?**
is tests

2320fc1... by David Reiss <email address hidden>

Add force-continue-as-new signal to schedule workflow (#5034)

**What changed?**
Add `force-continue-as-new` signal to schedule workflow, to force it to
continue-as-new immediately.

**Why?**
This could be used to force all running schedules onto the newest
version of the workflow code, to allow retiring older code paths.

**How did you test it?**
unit test

b8163ce... by David Reiss <email address hidden>

Use ContinueAsNewSuggested in scheduler workflow (#4990)

**What changed?**
Scheduler workflow uses server-sent suggestion for when to
continue-as-new instead of fixed iteration count.

Note this is not enabled in this PR yet.

**Why?**
Automatically handle history size/event count too large conditions (or
any future conditions added by the server), which we might get if we do
more work than expected per iteration.

**How did you test it?**
new unit tests, also replaced for loop with previous version to verify
actual iteration count didn't change

**Potential risks**
The default history size suggestion is at 4MB, which we could hit after
just a few large payload responses, and then we'd do continue-as-new
more often than we might like.