~maas-committers/maas/+git/temporal:norbert/branch-token-with-shard-id

Last commit made on 2024-03-08
Get this branch:
git clone -b norbert/branch-token-with-shard-id https://git.launchpad.net/~maas-committers/maas/+git/temporal

Branch merges

Branch information

Name:
norbert/branch-token-with-shard-id
Repository:
lp:~maas-committers/maas/+git/temporal

Recent commits

42efbd8... by Norbert Hu <email address hidden>

Prototyping passing shard id to branch token creation

150b259... by Stephan Behnke <email address hidden>

Mark PRs as stale after 6mo (#5491)

## What changed?
<!-- Describe what has changed in this PR -->

Mark Pull Requests - but not Issues - as stale after 120 days.

## Why?

Nudge author to either close or resurrect their PR from its slumber.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->

## Potential risks

None. The "stale" label simply can be removed by the author; no PR is
closed automatically.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

ec09daa... by Roey Berman <email address hidden>

Nexus accumulated work (#5225)

This PR is intended to merge 4 months of work in the `nexus` feature
branch into `main`.

The functionality it brings is:
- Dispatching Nexus Tasks by namespace and task queue
- Internal implementation of the Incoming Service Registry - not yet
exposed
- Attaching workflow close callbacks on `StartWorkflowExecutionRequest`
and processing of those callbacks

There's more to come and some of the callback code will be refactored
into a new plugin architecture
(https://github.com/temporalio/temporal/pull/5446) soon.

---------

Co-authored-by: PJ Doerner <email address hidden>

0a99412... by Stephan Behnke <email address hidden>

Add Terminate-if-Running test (#5483)

## What changed?

Added a test for Start Workflow + Terminate-if-Running.

Also refactored the existing test cases to make them more explicit, have
less duplication, less clever looping.

## Why?

Adding a test for Terminate-if-Running behavior for changing its
behavior in an upcoming PR (related to
https://github.com/temporalio/api/pull/359).

## How did you test it?

Is test.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

d59dd08... by Yimin Chen <email address hidden>

Validate normal TQ on sticky poll (#5488)

## What changed?
Validate normal TQ on sticky poll

## Why?
On sticky poll, we fetch normal TQ's UserData. So an invalid normal TQ
on a sticky queue would still trigger a load for the invalid normal
queue.

## How did you test it?
Manual test with invalid TQ.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

dcf403f... by Yimin Chen <email address hidden>

Add validation for a few string fields (#5487)

## What changed?
Add string validation for a few string fields

## Why?
Since we disable utf8 string validation from proto level, we want to
enforce minimal validation for some key fields.

## How did you test it?
Unit tests

## Potential risks
No

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

e819c3a... by Stephan Behnke <email address hidden>

Allow Update to use custom workflow lease (#5471)

## What changed?
<!-- Describe what has changed in this PR -->

(1) Allow to run an Update operation with a custom `WorkflowLease`.
(2) Separate the WorkflowLease-specific step from the post-WorkflowLease
steps.

## Why?

This is a refactoring to enable Update-With-Start. It requires these two
abilities mentioned above.

## How did you test it?

Existing test.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

---------

Co-authored-by: Alex Shtin <email address hidden>

9da197b... by Stephan Behnke <email address hidden>

disable cyclomatic/cognitive complexity for all tests (#5484)

## What changed?

Expanded the lint exclusion rules to include not just functional tests
but all tests.

## Why?

When using subtests, it's easy to get an unhelpful "cyclomatic
complexity" error.

## How did you test it?

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->

03d519b... by Alex Shtin <email address hidden>

Use historyrequire.HistoryRequire to assert on histories in tests (#5479)

## What changed?
<!-- Describe what has changed in this PR -->
Use `historyrequire.HistoryRequire` to assert on histories in tests.

## Why?
<!-- Tell your future self why have you made these changes -->
To make tests more readable and unify history assertions.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Run all tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No risks.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
No.

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.

742f42b... by Stephan Behnke <email address hidden>

remove print from test (#5481)

## What changed?
<!-- Describe what has changed in this PR -->

Removed `println`s from test.

## Why?

Don't need them.

## How did you test it?

Is test.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->