Merge lp:~m4sk1n/ubuntu-packaging-guide/ubuntu-packaging-guide into lp:ubuntu-packaging-guide

Proposed by Marcin Mikołajczak on 2017-12-18
Status: Merged
Merged at revision: 638
Proposed branch: lp:~m4sk1n/ubuntu-packaging-guide/ubuntu-packaging-guide
Merge into: lp:ubuntu-packaging-guide
Diff against target: 88 lines (+11/-11)
2 files modified
ubuntu-packaging-guide/getting-set-up.rst (+1/-1)
ubuntu-packaging-guide/packaging-new-software.rst (+10/-10)
To merge this branch: bzr merge lp:~m4sk1n/ubuntu-packaging-guide/ubuntu-packaging-guide
Reviewer Review Type Date Requested Status
Simon Quigley 2017-12-18 Needs Fixing on 2017-12-18
Review via email: mp+335342@code.launchpad.net

Description of the Change

“latest Ubuntu version of Ubuntu” makes no sense

To post a comment you must log in.
Simon Quigley (tsimonq2) wrote :

Comments added inline; once those are done I'll be happy to merge.

Nice way to get ahead and figure out the workflow before you start the GCI task, by the way. ;)

review: Needs Fixing
638. By Marcin Mikołajczak <email address hidden> on 2017-12-19

Fix noticed mistakes

Dmitry Shachnev (mitya57) wrote :

Merged, thanks! In future, please use better commit messages: your last commit not only fixes the review comments, but also updates an unrelated file.

Dmitry Shachnev (mitya57) wrote :

Or in case you meant the mistakes in the guide itself, then the commit message is perfectly fine. Sorry for the noise :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu-packaging-guide/getting-set-up.rst'
2--- ubuntu-packaging-guide/getting-set-up.rst 2017-09-07 22:38:12 +0000
3+++ ubuntu-packaging-guide/getting-set-up.rst 2017-12-19 16:09:18 +0000
4@@ -23,7 +23,7 @@
5 Ubuntu. Doing so will allow you to test changes in the same environment where
6 those changes will actually be applied and used.
7
8- Don't want to install the latest Ubuntu development version of Ubuntu? Spin
9+ Don't want to install the latest development version of Ubuntu? Spin
10 up an `LXD container <https://help.ubuntu.com/lts/serverguide/lxd.html>`_.
11
12 Install basic packaging software
13
14=== modified file 'ubuntu-packaging-guide/packaging-new-software.rst'
15--- ubuntu-packaging-guide/packaging-new-software.rst 2017-09-07 22:38:12 +0000
16+++ ubuntu-packaging-guide/packaging-new-software.rst 2017-12-19 16:09:18 +0000
17@@ -26,8 +26,8 @@
18
19 Now uncompress it::
20
21- $ tar xf hello-2.7.tar.gz
22- $ cd hello-2.7
23+ $ tar xf hello-2.10.tar.gz
24+ $ cd hello-2.10
25
26 This application uses the autoconf build system so we want to run ``./configure``
27 to prepare for compilation.
28@@ -58,7 +58,7 @@
29
30 $ sudo apt-get install dh-make bzr-builddeb
31 $ cd ..
32- $ bzr dh-make hello 2.7 hello-2.7.tar.gz
33+ $ bzr dh-make hello 2.10 hello-2.10.tar.gz
34
35 When it asks what type of package type ``s`` for single binary. This will import
36 the code into a branch and add the ``debian/`` packaging directory. Have a look
37@@ -72,7 +72,7 @@
38 You should now customise each of the files.
39
40 In ``debian/changelog`` change the
41-version number to an Ubuntu version: ``2.7-0ubuntu1`` (upstream version 2.7,
42+version number to an Ubuntu version: ``2.10-0ubuntu1`` (upstream version 2.10,
43 Debian version 0, Ubuntu version 1). Also change ``unstable`` to the current
44 development Ubuntu release such as ``trusty``.
45
46@@ -133,12 +133,12 @@
47
48 You can view the contents of the package with::
49
50- $ lesspipe hello_2.7-0ubuntu1_amd64.deb
51+ $ lesspipe hello_2.10-0ubuntu1_amd64.deb
52
53 Install the package and check it works (later you will be able to uninstall it
54 using ``sudo apt-get remove hello`` if you want)::
55
56- $ sudo dpkg --install hello_2.7-0ubuntu1_amd64.deb
57+ $ sudo dpkg --install hello_2.10-0ubuntu1_amd64.deb
58
59 You can also install all packages at once using::
60
61@@ -152,8 +152,8 @@
62 ``lintian`` which can be run on the source .dsc metadata file, .deb
63 binary packages or .changes file::
64
65- $ lintian hello_2.7-0ubuntu1.dsc
66- $ lintian hello_2.7-0ubuntu1_amd64.deb
67+ $ lintian hello_2.10-0ubuntu1.dsc
68+ $ lintian hello_2.10-0ubuntu1_amd64.deb
69
70 To see verbose description of the problems use ``--info`` lintian flag
71 or ``lintian-info`` command.
72@@ -177,7 +177,7 @@
73
74 $ bzr builddeb -S
75 $ cd ../build-area
76- $ pbuilder-dist trusty build hello_2.7-0ubuntu1.dsc
77+ $ pbuilder-dist trusty build hello_2.10-0ubuntu1.dsc
78
79 When you are happy with your package you will want others to review it. You
80 can upload the branch to Launchpad for review::
81@@ -188,7 +188,7 @@
82 others to test the binary packages. You will need to set up a PPA in Launchpad
83 and then upload with ``dput``::
84
85- $ dput ppa:<lp-username>/<ppa-name> hello_2.7-0ubuntu1.changes
86+ $ dput ppa:<lp-username>/<ppa-name> hello_2.10-0ubuntu1.changes
87
88 See :doc:`uploading<./udd-uploading>` for more information.
89

Subscribers

People subscribed via source and target branches