Merge lp:~m-alaa8/ubuntu/quantal/im-switch/fix-for-621204 into lp:ubuntu/quantal/im-switch

Proposed by Mohamed Alaa on 2012-10-04
Status: Work in progress
Proposed branch: lp:~m-alaa8/ubuntu/quantal/im-switch/fix-for-621204
Merge into: lp:ubuntu/quantal/im-switch
Diff against target: 27 lines (+8/-1)
2 files modified
debian/changelog (+7/-0)
im-switch.in (+1/-1)
To merge this branch: bzr merge lp:~m-alaa8/ubuntu/quantal/im-switch/fix-for-621204
Reviewer Review Type Date Requested Status
Mathieu Trudel-Lapierre Needs Fixing on 2012-10-16
Jamie Strandboge Resubmit on 2012-10-15
Ubuntu branches 2012-10-04 Pending
Review via email: mp+128037@code.launchpad.net
To post a comment you must log in.
Jamie Strandboge (jdstrand) wrote :

Thanks for your patch. It looks fine but it is too late in the 12.10 cycle to upload this, and it is not worthy of an SRU. Can you resubmit this after 13.04 opens? Thanks again.

review: Resubmit
Mohamed Alaa (m-alaa8) wrote :

> Thanks for your patch. It looks fine but it is too late in the 12.10 cycle to
> upload this, and it is not worthy of an SRU. Can you resubmit this after 13.04
> opens? Thanks again.
ok, sure i'll do this, many thanks :)
regards.

Mathieu Trudel-Lapierre (cyphermox) wrote :

Setting to "Work in progress" so as to not show this entry in the sponsoring overview.

To resubmit after 13.04 opens, you'll want to file it against a new branch lp:ubuntu/<whatever r is called>/...; but this is still releasable as SRU -- could you adjust your branch to target quantal-proposed instead if you want to ship this as SRU (then look at http://wiki.ubuntu.com/StableReleaseUpdates#Procedures for the steps to take on the bug report), then mark this merge request back to Needs Review :)

review: Needs Fixing

Unmerged revisions

14. By Mohamed Alaa on 2012-10-04

* im-switch.in:
  - replace "imput" with "input" line 380 (LP: 621204).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-09-07 21:06:27 +0000
3+++ debian/changelog 2012-10-04 15:02:30 +0000
4@@ -1,3 +1,10 @@
5+im-switch (1.22ubuntu3) quantal; urgency=low
6+
7+ * im-switch.in:
8+ - replace "imput" with "input" line 380 (LP: 621204).
9+
10+ -- Mohamed Alaa <m-alaa8@ubuntu.com> Thu, 04 Oct 2012 17:33:52 +0300
11+
12 im-switch (1.22ubuntu2) quantal; urgency=low
13
14 * im-switch.desktop:
15
16=== modified file 'im-switch.in'
17--- im-switch.in 2011-06-06 21:06:36 +0000
18+++ im-switch.in 2012-10-04 15:02:30 +0000
19@@ -377,7 +377,7 @@
20 fi
21 fi
22 echo "Please read /usr/share/doc/im-switch/README.Debian.gz ."
23-echo "Please restart the X session to activate the selected Imput Method."
24+echo "Please restart the X session to activate the selected Input Method."
25 }
26
27 menuitem_im () {

Subscribers

People subscribed via source and target branches

to all changes: