Merge lp:~lyubodzhamov/gala/fix-1220179 into lp:gala/freya

Proposed by Lyubomir Dzhamov
Status: Rejected
Rejected by: Zisu Andrei
Proposed branch: lp:~lyubodzhamov/gala/fix-1220179
Merge into: lp:gala/freya
Diff against target: 12 lines (+3/-0)
1 file modified
src/WindowListener.vala (+3/-0)
To merge this branch: bzr merge lp:~lyubodzhamov/gala/fix-1220179
Reviewer Review Type Date Requested Status
Rico Tzschichholz Needs Fixing
Review via email: mp+295372@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Rico Tzschichholz (ricotz) wrote :

This looks like solving the problem if an application starts up.
But if a running application sets its urgency flag it will be raised as well which is not wanted.

review: Needs Fixing
Revision history for this message
Lyubomir Dzhamov (lyubodzhamov) wrote :

> This looks like solving the problem if an application starts up.
> But if a running application sets its urgency flag it will be raised as well
> which is not wanted.

Hi there Rico,
I'm new to the technology and I don't have very deep understanding of the window management mechanism yet.
Why don't we want to raise applications with urgency flag set? It is not stealing the input focus. My concern was if it is going to show on top of let's say a full screen video playing, but it is not happening.

Revision history for this message
Zisu Andrei (matzipan) wrote :

Rejecting since solution is not what is desired.

Unmerged revisions

482. By Lyubomir Dzhamov

--fixes lp:1220179

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/WindowListener.vala'
2--- src/WindowListener.vala 2015-03-12 14:10:18 +0000
3+++ src/WindowListener.vala 2016-05-20 22:39:58 +0000
4@@ -84,6 +84,9 @@
5 case "on-all-workspaces":
6 window_on_all_workspaces_changed (window);
7 break;
8+ case "demands-attention":
9+ window.raise ();
10+ break;
11 }
12 }
13

Subscribers

People subscribed via source and target branches