Merge lp:~lynxman/ubuntu/oneiric/apache2/fixeddefaultsite into lp:ubuntu/oneiric/apache2

Proposed by Marc Cluet
Status: Work in progress
Proposed branch: lp:~lynxman/ubuntu/oneiric/apache2/fixeddefaultsite
Merge into: lp:ubuntu/oneiric/apache2
Diff against target: 30 lines (+12/-1)
2 files modified
debian/changelog (+11/-0)
debian/config-dir/sites-available/default (+1/-1)
To merge this branch: bzr merge lp:~lynxman/ubuntu/oneiric/apache2/fixeddefaultsite
Reviewer Review Type Date Requested Status
James Page Disapprove
Ubuntu branches Pending
Review via email: mp+72172@code.launchpad.net

Description of the change

  * Changed default website config (LP: #820936)
    - debian/config-dir/sites-available/default: Changed Virtualhost
    definition to avoid bug LP: #820936

To post a comment you must log in.
71. By Marc Cluet

* Expanded changelog to explain more in depth the problem we solved with this fix

Revision history for this message
James Page (james-page) wrote :

Hi Marc

As we discussed via IRC this proposed change does not address bug 820936 due to the fact that in Apache 2.2 the rewrite engine plus inheritance have to be declared explicitly in all VirtualHost definitions , see http://httpd.apache.org/docs/2.2/mod/mod_rewrite.html#vhosts.

That said the change does make some sense as it makes the default host behave in a slight nicer way with other virtualhosts - however we should try to get this change in Debian first rather that risking an Ubuntu delta which we may have to carry.

Please could you submit a bug report back to Debian.

Cheers

James

review: Disapprove

Unmerged revisions

71. By Marc Cluet

* Expanded changelog to explain more in depth the problem we solved with this fix

70. By Marc Cluet

  * Changed default website config (LP: #820936)
    - debian/config-dir/sites-available/default: Changed Virtualhost
    definition to avoid bug LP: #820936

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-05-23 10:16:09 +0000
3+++ debian/changelog 2011-08-19 12:51:31 +0000
4@@ -1,5 +1,16 @@
5 apache2 (2.2.19-1ubuntu1) oneiric; urgency=low
6
7+ * Changed default website config (LP: #820936)
8+ - debian/config-dir/sites-available/default: Changed Virtualhost
9+ definition to avoid bug LP: #820936
10+ The definition of the default virtualhost as *:80 breaks Rewrite
11+ Rules outside the virtualhost scope, we changed that to _default:80
12+ as recommended by Apache itself
13+
14+ -- Marc Cluet <marc.cluet@ubuntu.com> Fri, 19 Aug 2011 12:08:17 +0100
15+
16+apache2 (2.2.19-1ubuntu1) oneiric; urgency=low
17+
18 * Merge from debian unstable (LP: #787013). Remaining changes:
19 - debian/{control, rules}: Enable PIE hardening.
20 - debian/{control, rules, apache2.2-common.ufw.profile}: Add ufw profiles.
21
22=== modified file 'debian/config-dir/sites-available/default'
23--- debian/config-dir/sites-available/default 2010-02-20 12:38:30 +0000
24+++ debian/config-dir/sites-available/default 2011-08-19 12:51:31 +0000
25@@ -1,4 +1,4 @@
26-<VirtualHost *:80>
27+<VirtualHost _default_:80>
28 ServerAdmin webmaster@localhost
29
30 DocumentRoot /var/www

Subscribers

People subscribed via source and target branches

to all changes: