Code review comment for ~lvoytek/ubuntu/+source/swtpm:add-sys-admin-oracular

Revision history for this message
Bryce Harrington (bryce) wrote :

All looks like it checks out.

Thank you for the almost-paint-by-numbers test cases, this will feed directly into the SRU test case. Only improvement would be a canned vm creation cmdline; I inadvertently created a container off the bat.

Oh, also minor note that this:

    $ sudo apt update && apt dist-upgrade -y

Should be:

    $ sudo apt update
    $ sudo apt dist-upgrade -y

Everything else looks good, and packaging work is correct. +1 LGTM.

review: Approve

« Back to merge proposal