Code review comment for ~lvoytek/ubuntu/+source/requests:remove-charset-normalizer-pybuild

Revision history for this message
Bryce Harrington (bryce) wrote :

Confirmed charset-normalizer is in universe, and makes sense that this delta will be ubuntu-specific.

I wonder if the reason chardet is in main is due to security concerns for charset-normalizer; if that is the case then it might be relevant to suggest Debian shift as well. But if the choice is just to keep duplicative code out of main, then yeah this can just live as delta from here. Thanks for annotating the change!

### Debian ###
python-charset-normalizer | 3.0.1-2 | bookworm
python-charset-normalizer | 3.3.2-1 | trixie
python-charset-normalizer | 3.3.2-1 | sid

### Ubuntu ###
python-charset-normalizer | 2.0.6-2 | jammy/universe
python-charset-normalizer | 3.2.0-1 | mantic/universe
python-charset-normalizer | 3.3.2-1 | noble/universe
python-charset-normalizer | 3.3.2-1 | oracular/universe

Test results, packaging and change itself LGTM, +1.

review: Approve

« Back to merge proposal