Merge ~lvoytek/ubuntu/+source/openvpn:MRE-jammy-2.5.9 into ubuntu/+source/openvpn:ubuntu/jammy-devel
Status: | Merged |
---|---|
Approved by: | git-ubuntu bot |
Approved revision: | not available |
Merged at revision: | 92190dd39433831d4a2333b7bc97f49160f102e7 |
Proposed branch: | ~lvoytek/ubuntu/+source/openvpn:MRE-jammy-2.5.9 |
Merge into: | ubuntu/+source/openvpn:ubuntu/jammy-devel |
Diff against target: |
602 lines (+188/-40) 20 files modified
ChangeLog (+25/-0) Changes.rst (+32/-0) build/msvc/msvc-generate/Makefile.mak (+6/-3) configure (+13/-13) debian/changelog (+17/-0) doc/man-sections/protocol-options.rst (+7/-0) doc/openvpn.8 (+7/-0) doc/openvpn.8.html (+6/-0) include/openvpn-plugin.h (+1/-1) sample/sample-plugins/Makefile (+5/-5) src/openvpn/forward.c (+0/-3) src/openvpn/misc.c (+1/-0) src/openvpn/misc.h (+1/-0) src/openvpn/ntlm.c (+13/-0) src/openvpn/options.c (+10/-5) src/openvpn/push.c (+7/-5) src/openvpn/ssl_mbedtls.c (+7/-1) src/openvpn/ssl_ncp.c (+14/-2) tests/unit_tests/openvpn/test_ncp.c (+14/-0) version.m4 (+2/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
git-ubuntu bot | Approve | ||
Lucas Kanashiro (community) | Approve | ||
Andreas Hasenack | Pending | ||
Canonical Server Reporter | Pending | ||
Review via email: mp+449214@code.launchpad.net |
Description of the change
MRE for version 2.5.9 in Jammy with the caveat that each upstream commit is checked for backwards-
OpenVPN is currently rejected as an MRE, but the SRU team has agreed to accept version updates in Jammy provided that they are aware of changes that may break an existing user's setup. For more context see: https:/
Going through all 12 commits I found no additions that would break a user's setup, and there was only one change that contains a feature update. The new feature allows users to include optional cipher algorithms in the --data-ciphers option.
PPA: https:/
Autopkgtest results:
openvpn @ amd64:
15.08.23 20:09:34 Log 🗒️ ✅ Triggers: openvpn/
openvpn @ arm64:
15.08.23 20:27:18 Log 🗒️ ✅ Triggers: openvpn/
openvpn @ armhf:
15.08.23 20:07:48 Log 🗒️ ✅ Triggers: openvpn/
openvpn @ ppc64el:
15.08.23 20:10:28 Log 🗒️ ✅ Triggers: openvpn/
openvpn @ s390x:
15.08.23 20:15:29 Log 🗒️ ✅ Triggers: openvpn/
Thanks for this MP Lena!
I reviewed all changes related to version 2.5.9 (nothing from 2.5.8 that is already in jammy-proposed), and I agree with your analysis. There is this single change introducing a new feature (--data-ciphers) which is optional. I do not think there will be a push back from the SRU team because of this since it will not change any behavior for existing users.
Build, tests, changelog, bug description... everything looks good to me! +1.