Merge ~lvoytek/ubuntu/+source/django-menu-generator-ng:fix-django4-compatibility into ubuntu/+source/django-menu-generator-ng:ubuntu/devel

[Lena Voytek]

Adding Django 4.2 support for the transition in mantic. The package just needed a fix in its urls test file, using re_path instead of the removed url() function.

PPA building against 4.2: https://launchpad.net/~lvoytek/+archive/ubuntu/django-4-mantic
PPA building against 3.2 (currently in Ubuntu): https://launchpad.net/~lvoytek/+archive/ubuntu/django3-mantic

[Lucas Kanashiro (lucaskanashiro)]

Thanks for this MP Lena! I see you are trying to make this package work with Django 4 but it seems to me dead upstream, not sure if it worth to be kept in the archive TBH. The last and unique upload to Debian was in 2021:

https://tracker.debian.org/pkg/django-menu-generator-ng

The upstream git repo is archived:

https://edugit.org/AlekSIS/libs/django-menu-generator-ng

It's never migrated to Debian testing, it is stuck in unstable since the initial upload.

Moreover, it has no reverse dependencies:

$ reverse-depends -r mantic src:django-menu-generator-ng
No reverse dependencies found
$ reverse-depends -r mantic src:django-menu-generator-ng -a source
No reverse dependencies found

So my advice here would be to file a RM bug against the Debian and Ubuntu. IMHO this is the best way out of unblocking the Django 4 transition.

review: Needs Information

[Lena Voytek (lvoytek)]

I think that's fair. I'll go ahead and file bugs for it since that'll likely be more convenient long term.

[Lena Voytek (lvoytek)]

Added Ubuntu bug for removal here: https://bugs.launchpad.net/ubuntu/+source/django-menu-generator-ng/+bug/2029421

I'll change this mp to work in progress for now

Unmerged commits

00c1a3d... by Lena Voytek on 2023-07-31

changelog

88b7c7c... by Lena Voytek on 2023-07-31

update maintainer

0323490... by Lena Voytek on 2023-07-31

* django4-compatibility.patch: Fix Django 4 compatibility with re_path
  (LP: #2022089)

diff --git a/debian/changelog b/debian/changelog
index de0a779..ff4b721 100644
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,10 @@
+django-menu-generator-ng (1.2.3-1ubuntu1) mantic; urgency=medium
+
+  * django4-compatibility.patch: Fix Django 4 compatibility with re_path
+    (LP: #2022089)
+
+ -- Lena Voytek <[e-mail]>  Mon, 31 Jul 2023 15:16:10 -0700
+
 django-menu-generator-ng (1.2.3-1) unstable; urgency=low
 
   * Initial release
diff --git a/debian/control b/debian/control
index f49fb7e..eb0555b 100644
--- a/debian/control
+++ b/debian/control
@@ -1,5 +1,6 @@
 Source: django-menu-generator-ng
-Maintainer: Debian Python Team <[e-mail]>
+Maintainer: Ubuntu Developers <[e-mail]>
+XSBC-Original-Maintainer: Debian Python Team <[e-mail]>
 Uploaders: Dominik George <[e-mail]>
 Section: python
 Priority: optional
diff --git a/debian/patches/django4-compatibility.patch b/debian/patches/django4-compatibility.patch
new file mode 100644
index 0000000..157afbd
--- /dev/null
+++ b/debian/patches/django4-compatibility.patch
@@ -0,0 +1,28 @@
+Description: Fix compatibility with Django 4 by replacing django.conf.urls with re_path
+ As of Django 4, the django.conf.urls.url() function was removed. The
+ recommended replacement is to use re_path for url paths that use regex. This
+ patch replaces instances of the url function accordingly.
+Author: Lena Voytek <[e-mail]>
+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/mantic/+source/django-menu-generator-ng/+bug/2022089
+Last-Update: 2023-07-31
+---
+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
+--- a/menu_generator/tests/urls.py
++++ b/menu_generator/tests/urls.py
+@@ -1,11 +1,11 @@
+-from django.conf.urls import url
++from django.urls import re_path
+ 
+ def testview(request):
+     return 'foo'
+ 
+ urlpatterns = [
+-    url(r'named-url', lambda: 'foo', name='named_url'),
+-    url(r'named-with-params/(?P<pk>\d+)/', lambda: 'foo', name='named_with_params'),
+-    url(r'known-view', testview, name='known_view'),
+-    url(r'', lambda: 'foo'),
++    re_path(r'named-url', lambda: 'foo', name='named_url'),
++    re_path(r'named-with-params/(?P<pk>\d+)/', lambda: 'foo', name='named_with_params'),
++    re_path(r'known-view', testview, name='known_view'),
++    re_path(r'', lambda: 'foo'),
+ ]
diff --git a/debian/patches/series b/debian/patches/series
new file mode 100644
index 0000000..2c430ea
--- /dev/null
+++ b/debian/patches/series
@@ -0,0 +1 @@
+django4-compatibility.patch