Merge ~lvoytek/ubuntu/+source/django-mailman3:add-django4-support-mantic into ubuntu/+source/django-mailman3:ubuntu/devel

Proposed by Lena Voytek
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merge reported by: Lena Voytek
Merged at revision: 5f04a2ffa2d44fda3cd94a7d0f9effbd0fdd94ff
Proposed branch: ~lvoytek/ubuntu/+source/django-mailman3:add-django4-support-mantic
Merge into: ubuntu/+source/django-mailman3:ubuntu/devel
Diff against target: 89 lines (+51/-2)
4 files modified
debian/changelog (+9/-0)
debian/control (+3/-2)
debian/patches/django4-compatibility.patch (+38/-0)
debian/patches/series (+1/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Lucas Kanashiro (community) Approve
Canonical Server Reporter Pending
Review via email: mp+448078@code.launchpad.net

Description of the change

Adding Django 4.2 support to django-mailman3 for the transition to 4.2 in mantic

PPA building against 4.2: https://launchpad.net/~lvoytek/+archive/ubuntu/django-4-mantic
PPA building against 3.2 (currently in Ubuntu): https://launchpad.net/~lvoytek/+archive/ubuntu/django3-mantic

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks for this MP Lena! There is a minor change I think we should apply in the patch's DEP-3 headers.

review: Needs Fixing
dc8b6a4... by Lena Voytek

  * d/p/django4-compatibility.patch: Add Django 4.2 compatibility
  (LP: #2022089)

Revision history for this message
Lena Voytek (lvoytek) wrote :

Thanks for the review Lucas! That's a good point, updated the header

Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Thanks Lena! LGTM now, +1.

review: Approve
Revision history for this message
Lena Voytek (lvoytek) wrote :

Thanks! Would you be willing to sponsor this one? Unfortunately most django packages just belong to motu

Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: lucaskanashiro, lvoytek
Uploaders: lucaskanashiro
MP auto-approved

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

Sure, package uploaded:

Uploading django-mailman3_1.3.9-1ubuntu1.dsc
Uploading django-mailman3_1.3.9-1ubuntu1.debian.tar.xz
Uploading django-mailman3_1.3.9-1ubuntu1_source.changes

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index 36eb645..e92bde8 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+django-mailman3 (1.3.9-1ubuntu1) mantic; urgency=medium
7+
8+ * Add Django 4.2 compatibility (LP: #2022089)
9+ - d/p/django4-compatibility.patch: Add Django 4.2 as a possible dependency
10+ in setup.py and provide a tox environment for it
11+ - d/control: Allow Django 4.2 as a dependency
12+
13+ -- Lena Voytek <lena.voytek@canonical.com> Fri, 28 Jul 2023 13:10:51 -0700
14+
15 django-mailman3 (1.3.9-1) unstable; urgency=medium
16
17 * New upstream release: 1.3.9
18diff --git a/debian/control b/debian/control
19index 2759b7e..02eef97 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -1,5 +1,6 @@
23 Source: django-mailman3
24-Maintainer: Debian Mailman Team <pkg-mailman-hackers@lists.alioth.debian.org>
25+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
26+XSBC-Original-Maintainer: Debian Mailman Team <pkg-mailman-hackers@lists.alioth.debian.org>
27 Uploaders: Pierre-Elliott Bécue <peb@debian.org>,
28 Jonas Meurer <jonas@freesources.org>
29 Section: python
30@@ -8,7 +9,7 @@ Build-Depends: debhelper-compat (= 13),
31 dh-python,
32 python3-all,
33 python3-django (>= 2:3.2),
34- python3-django (<< 3:4.2),
35+ python3-django (<< 3:4.3),
36 python3-django-allauth,
37 python3-django-compressor,
38 python3-django-gravatar2,
39diff --git a/debian/patches/django4-compatibility.patch b/debian/patches/django4-compatibility.patch
40new file mode 100644
41index 0000000..9e1e5cb
42--- /dev/null
43+++ b/debian/patches/django4-compatibility.patch
44@@ -0,0 +1,38 @@
45+Description: Mark Django versions 3.2 to 4.2 as compatible
46+ This is a modified version of an upstream commit that ignores changes to the
47+ README.rst and .gitlab-ci.yml files, only using changes relevant to tox and
48+ setup.py.
49+Author: Mark Sapiro <mark@msapiro.net>
50+Origin: backport, https://gitlab.com/mailman/django-mailman3/-/commit/583544cc5d79dc8e5b9f647bfadf8212a6f67451
51+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/django-mailman3/+bug/2022089
52+Last-Update: 2023-07-28
53+---
54+This patch header follows DEP-3: http://dep.debian.net/deps/dep3/
55+--- a/setup.py
56++++ b/setup.py
57+@@ -38,7 +38,7 @@
58+ packages=find_packages(),
59+ include_package_data=True,
60+ install_requires=[
61+- 'django>=3.2,<4.2',
62++ 'django>=3.2,<4.3',
63+ 'mailmanclient>=3.3.3',
64+ 'django-allauth',
65+ 'django-gravatar2 >= 1.0.6',
66+--- a/tox.ini
67++++ b/tox.ini
68+@@ -1,5 +1,5 @@
69+ [tox]
70+-envlist = py{37,38,39,310.311}-django{32,40,41,latest},lint
71++envlist = py{37,38,39,310.311}-django{32,40,41,42,latest},lint
72+
73+
74+ [testenv]
75+@@ -10,6 +10,7 @@
76+ django32: django>=3.2,<3.3
77+ django40: django>=4.0,<4.1
78+ django41: django>=4.1,<4.2
79++ django42: django>=4.2,<4.3
80+ pytest-django
81+ djangolatest: https://github.com/django/django/archive/main.tar.gz
82+ coverage: pytest-cov
83diff --git a/debian/patches/series b/debian/patches/series
84new file mode 100644
85index 0000000..2c430ea
86--- /dev/null
87+++ b/debian/patches/series
88@@ -0,0 +1 @@
89+django4-compatibility.patch

Subscribers

People subscribed via source and target branches

to all changes: