Merge ~lvoytek/ubuntu/+source/django-cachalot:django4-compatibility into ubuntu/+source/django-cachalot:ubuntu/devel

Proposed by Lena Voytek
Status: Merged
Approved by: git-ubuntu bot
Approved revision: not available
Merged at revision: 219779c82d9b3b6d7963689a67bdab1aa957c9ae
Proposed branch: ~lvoytek/ubuntu/+source/django-cachalot:django4-compatibility
Merge into: ubuntu/+source/django-cachalot:ubuntu/devel
Diff against target: 48 lines (+16/-2)
3 files modified
debian/changelog (+9/-0)
debian/control (+2/-2)
debian/tests/control (+5/-0)
Reviewer Review Type Date Requested Status
git-ubuntu bot Approve
Sergio Durigan Junior (community) Approve
Canonical Server Pending
Canonical Server Reporter Pending
Review via email:

Description of the change

Allow Django 4 as a build dependency for cachalot by removing upper version limit in d/control. This is how it was updated in Debian Salsa, but the newer version has yet to be uploaded -


To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lena.

While looking at the upstream releases I noticed that the Django 4.0 support has been implemented in 2.4.5 (by I couldn't find any backported patches to implement such support in the version we have in the archive. I see that the build passes against Django 4.0 with your proposed change, but are we sure that the package will work? I'm just trying to cover all bases before we go ahead and upload this MP. Thanks.

review: Needs Information
Revision history for this message
Lena Voytek (lvoytek) wrote :

Yeah the package should work with Django 4 as is. The upstream changes to fully support Django 4 are all related to github ci, tox, docs, and the testing framework. It would be nice to update the testing framework, especially if a DEP-8 test was created using it, but isn't necessary for building or running the package.

Revision history for this message
Lena Voytek (lvoytek) wrote :

Ah actually I forgot about autodep8, the test suite should actually be updated. I'll get that added

Revision history for this message
Lena Voytek (lvoytek) wrote :

Autodep8 was actually failing because the module name is cachalot rather than django_cachalot. So I overrode the test with the other name. That means the test suite fixes aren't actually needed. If another autopkgtest for upstream tests was created though then it would be needed. Here are the results now:

autopkgtest [11:32:38]: @@@@@@@@@@@@@@@@@@@@ summary
command1 PASS (superficial)
qemu-system-x86_64: terminating on signal 15 from pid 57842 (/usr/bin/python3)

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lena.

Given your explanation that the package works with Django 4 as is, this LGTM.


$ dput django-cachalot_2.4.3-2ubuntu1_source.changes
Trying to upload package to ubuntu
Checking signature on .changes
gpg: /home/sergio/work/django-cachalot/django-cachalot_2.4.3-2ubuntu1_source.changes: Valid signature from 106DA1C8C3CBBF14
Checking signature on .dsc
gpg: /home/sergio/work/django-cachalot/django-cachalot_2.4.3-2ubuntu1.dsc: Valid signature from 106DA1C8C3CBBF14
Uploading to ubuntu (via ftp to
  Uploading django-cachalot_2.4.3-2ubuntu1.dsc: done.
  Uploading django-cachalot_2.4.3-2ubuntu1.debian.tar.xz: done.
  Uploading django-cachalot_2.4.3-2ubuntu1_source.buildinfo: done.
  Uploading django-cachalot_2.4.3-2ubuntu1_source.changes: done.
Successfully uploaded packages.

review: Approve
Revision history for this message
git-ubuntu bot (git-ubuntu-bot) wrote :

Approvers: sergiodj, lvoytek
Uploaders: sergiodj
MP auto-approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/changelog b/debian/changelog
2index f80f036..48a4b95 100644
3--- a/debian/changelog
4+++ b/debian/changelog
5@@ -1,3 +1,12 @@
6+django-cachalot (2.4.3-2ubuntu1) mantic; urgency=medium
8+ * d/control: Remove restriction on later Django versions, allowing 4.0+
9+ (LP: #2022089)
10+ * d/t/control: Replace autodep8 test, using cachalot as the module name
11+ rather than django_cachalot
13+ -- Lena Voytek <> Fri, 25 Aug 2023 12:35:25 -0700
15 django-cachalot (2.4.3-2) unstable; urgency=medium
17 * Team upload.
18diff --git a/debian/control b/debian/control
19index 7ac6b6e..64bbd38 100644
20--- a/debian/control
21+++ b/debian/control
22@@ -1,5 +1,6 @@
23 Source: django-cachalot
24-Maintainer: Debian Python Team <>
25+Maintainer: Ubuntu Developers <>
26+XSBC-Original-Maintainer: Debian Python Team <>
27 Uploaders: Dominik George <>
28 Section: python
29 Priority: optional
30@@ -8,7 +9,6 @@ Build-Depends:
31 dh-python,
32 python3-all,
33 python3-django (>= 2:2.2~),
34- python3-django (<< 3:3.3~),
35 python3-setuptools,
36 Standards-Version: 4.6.0
37 Homepage:
38diff --git a/debian/tests/control b/debian/tests/control
39new file mode 100644
40index 0000000..47de517
41--- /dev/null
42+++ b/debian/tests/control
43@@ -0,0 +1,5 @@
44+Test-Command: for py in $(py3versions -r 2>/dev/null) ; do cd "$AUTOPKGTEST_TMP" ; echo "Testing with $py:" ; $py -c "import cachalot; print(cachalot)" ; done
46+ python3-all,
47+ @,
48+Restrictions: superficial


People subscribed via source and target branches

to all changes: