Merge lp:~lutostag/charms/trusty/ci-configurator/trusty-distro-jjb-fix into lp:~matsubara/charms/trusty/ci-configurator/trunk

Proposed by Greg Lutostanski
Status: Merged
Merged at revision: 89
Proposed branch: lp:~lutostag/charms/trusty/ci-configurator/trusty-distro-jjb-fix
Merge into: lp:~matsubara/charms/trusty/ci-configurator/trunk
Diff against target: 20 lines (+2/-2)
1 file modified
hooks/jjb.py (+2/-2)
To merge this branch: bzr merge lp:~lutostag/charms/trusty/ci-configurator/trusty-distro-jjb-fix
Reviewer Review Type Date Requested Status
Diogo Matsubara Pending
Review via email: mp+281761@code.launchpad.net

Description of the change

One fix to fail-fast on run parts.
One fix to not use --flush-cache (because packaged version of jjb in trusty does not have support for that flag)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'hooks/jjb.py'
2--- hooks/jjb.py 2015-09-02 21:21:03 +0000
3+++ hooks/jjb.py 2016-01-06 15:31:22 +0000
4@@ -278,7 +278,7 @@
5 # because it comes after a restart, so needs time
6 for attempt in range(MAX_RETRIES):
7 try:
8- cmd = ['jenkins-jobs', '--flush-cache', 'update', JOBS_CONFIG_DIR]
9+ cmd = ['jenkins-jobs', 'update', JOBS_CONFIG_DIR]
10 # Run as the CI_USER so the cache will be primed with the correct
11 # permissions (rather than root:root).
12 common.run_as_user(cmd=cmd, user=common.CI_USER)
13@@ -315,7 +315,7 @@
14 # run repo setup scripts.
15 setupd = os.path.join(common.CI_CONFIG_DIR, 'setup.d')
16 if os.path.isdir(setupd):
17- cmd = ["run-parts", setupd]
18+ cmd = ["run-parts", "--exit-on-error", setupd]
19 log('Running repo setup.')
20 subprocess.check_call(cmd)
21

Subscribers

People subscribed via source and target branches