Code review comment for lp:~lukas-kde/unity8/windowOpenCloseAnimations

Revision history for this message
Michael Zanetti (mzanetti) wrote :

> On (maxed) window closing, I definitely do get the scale/opacity change
> although I agree when opening maximized windows, the animation is not there:
>
> From WindowResizeArea.qml (r. 1978.4.2 <email address hidden>
> 20150925)
>
> if (windowState === WindowStateStorage.WindowStateMaximized) {
> target.maximize(false)
> }
>
> Not sure what the intention is here

The issue I was solving with this is that otherwise a maximized window would start normal and then aminate to fullscreen. We might need to rework that a little to make the open animation play but not the maximize animation.

« Back to merge proposal