Code review comment for lp:~lukas-kde/unity8/windowOpenCloseAnimations

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> - The app closing animation seems to "stick" on the last frame. Or not
> smoothly go down to zero opacity. Or something. It didn't look right on my
> mako.

Agree, using the standard UbuntuNumberAnimation feels much smoother, at least here

> - closeApplication() takes two arguments, normally only using the first one.
> It uses the appId if the first argument is not given, which is an odd
> construction. Maybe just drop the second argument completely, as it's never
> used?


> Otherwise already looks nice. :)

« Back to merge proposal