Merge lp:~lukas-kde/unity8/stabilizeWizardTests into lp:unity8
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid on 2016-04-20 |
| Approved revision: | 2333 |
| Merged at revision: | 2348 |
| Proposed branch: | lp:~lukas-kde/unity8/stabilizeWizardTests |
| Merge into: | lp:unity8 |
| Diff against target: |
11 lines (+1/-0) 1 file modified
tests/qmltests/Wizard/tst_Wizard.qml (+1/-0) |
| To merge this branch: | bzr merge lp:~lukas-kde/unity8/stabilizeWizardTests |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | 2016-04-17 | Approve on 2016-04-20 | |
| Unity8 CI Bot | continuous-integration | Needs Fixing on 2016-04-19 | |
|
Review via email:
|
|||
Commit Message
Stabilize wizard tests
Description of the Change
Stabilize wizard tests
The TZ page takes too long in britney
| Albert Astals Cid (aacid) wrote : | # |
It doesn't make sense to verify after waitForRendering, verify that the thing exists should be before asking it to check it does finish its rendering
- 2333. By Lukáš Tinkl on 2016-04-19
-
verify before wait
| Lukáš Tinkl (lukas-kde) wrote : | # |
> It doesn't make sense to verify after waitForRendering, verify that the thing
> exists should be before asking it to check it does finish its rendering
Fixed
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2333
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Unity8 CI Bot (unity8-ci-bot) wrote : | # |
FAILED: Continuous integration, rev:2333
https:/
Executed test runs:
UNSTABLE: https:/
SUCCESS: https:/
UNSTABLE: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/
| Albert Astals Cid (aacid) wrote : | # |
* Did you perform an exploratory manual test run of the code change and any related functionality?
Difficult to prove it fixes it, but looks good
* Did CI run pass?
Some unrelated dash thing segfaulted :/
* Did you make sure that the branch does not contain spurious tags?
Yes
FAILED: Continuous integration, rev:2332
https:/
Executed test runs:
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
SUCCESS: https:/
deb: https:/
FAILURE: https:/
SUCCESS: https:/
deb: https:/
Click here to trigger a rebuild:
https:/