Merge lp:~lukas-kde/unity8/removePhoneMentions into lp:unity8
Proposed by
Lukáš Tinkl
Status: | Merged |
---|---|
Approved by: | Andrea Cimitan |
Approved revision: | 2174 |
Merged at revision: | 2194 |
Proposed branch: | lp:~lukas-kde/unity8/removePhoneMentions |
Merge into: | lp:unity8 |
Diff against target: |
37 lines (+3/-3) 3 files modified
qml/Wizard/Pages/10-welcome.qml (+1/-1) qml/Wizard/Pages/30-passwd-type.qml (+1/-1) qml/Wizard/Pages/80-finished.qml (+1/-1) |
To merge this branch: | bzr merge lp:~lukas-kde/unity8/removePhoneMentions |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
Unity8 CI Bot | continuous-integration | Needs Fixing | |
Andrea Cimitan (community) | Approve | ||
Review via email: mp+285466@code.launchpad.net |
Commit message
Replace the word "phone" with a more generic term "device" in the welcome wizard
Description of the change
Replace the word "phone" with a more generic term "device" in the welcome wizard
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* Did you make sure that your branch does not contain spurious tags?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes
* If you changed the UI, has there been a design review?
Yes
To post a comment you must log in.
* Did you perform an exploratory manual test run of the code change and any related functionality?
just a string change agreed with design
* Did CI run pass? If not, please explain why.
* Did you make sure that the branch does not contain spurious tags?
clean