Merge lp:~lukas-kde/unity8/removePhoneMentions into lp:unity8

Proposed by Lukáš Tinkl
Status: Merged
Approved by: Andrea Cimitan
Approved revision: 2174
Merged at revision: 2194
Proposed branch: lp:~lukas-kde/unity8/removePhoneMentions
Merge into: lp:unity8
Diff against target: 37 lines (+3/-3)
3 files modified
qml/Wizard/Pages/10-welcome.qml (+1/-1)
qml/Wizard/Pages/30-passwd-type.qml (+1/-1)
qml/Wizard/Pages/80-finished.qml (+1/-1)
To merge this branch: bzr merge lp:~lukas-kde/unity8/removePhoneMentions
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Needs Fixing
Unity8 CI Bot continuous-integration Needs Fixing
Andrea Cimitan (community) Approve
Review via email: mp+285466@code.launchpad.net

Commit message

Replace the word "phone" with a more generic term "device" in the welcome wizard

Description of the change

Replace the word "phone" with a more generic term "device" in the welcome wizard

* Are there any related MPs required for this MP to build/function as expected? Please list.

No

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* Did you make sure that your branch does not contain spurious tags?

Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

Yes

* If you changed the UI, has there been a design review?

Yes

To post a comment you must log in.
2174. By Lukáš Tinkl

also the screenlock page

Revision history for this message
Andrea Cimitan (cimi) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
just a string change agreed with design
 * Did CI run pass? If not, please explain why.
 * Did you make sure that the branch does not contain spurious tags?
clean

review: Approve
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2173
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/296/
Executed test runs:
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build/417/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/440
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/458
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/458
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/454
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/454/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/454/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/454
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/454/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/454/console
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/454
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/454/artifact/output/*zip*/output.zip
    FAILURE: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/454/console

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-1-ci/296/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Wizard/Pages/10-welcome.qml'
2--- qml/Wizard/Pages/10-welcome.qml 2015-07-15 15:07:19 +0000
3+++ qml/Wizard/Pages/10-welcome.qml 2016-02-09 12:36:40 +0000
4@@ -41,7 +41,7 @@
5 anchors.left: parent.left
6 anchors.right: parent.right
7 wrapMode: Text.Wrap
8- text: i18n.tr("Welcome to your Ubuntu phone.")
9+ text: i18n.tr("Welcome to your Ubuntu device.")
10 }
11
12 Label {
13
14=== modified file 'qml/Wizard/Pages/30-passwd-type.qml'
15--- qml/Wizard/Pages/30-passwd-type.qml 2016-01-07 20:14:56 +0000
16+++ qml/Wizard/Pages/30-passwd-type.qml 2016-02-09 12:36:40 +0000
17@@ -76,7 +76,7 @@
18 anchors.left: parent.left
19 anchors.right: parent.right
20 wrapMode: Text.Wrap
21- text: i18n.tr("Please select how you’d like to unlock your phone.")
22+ text: i18n.tr("Please select how you’d like to unlock your device.")
23 }
24
25 ItemSelector {
26
27=== modified file 'qml/Wizard/Pages/80-finished.qml'
28--- qml/Wizard/Pages/80-finished.qml 2015-07-15 15:07:19 +0000
29+++ qml/Wizard/Pages/80-finished.qml 2016-02-09 12:36:40 +0000
30@@ -43,7 +43,7 @@
31 anchors.left: parent.left
32 anchors.right: parent.right
33 wrapMode: Text.Wrap
34- text: i18n.tr("Your phone is now ready to use.")
35+ text: i18n.tr("Your device is now ready to use.")
36 }
37 }
38

Subscribers

People subscribed via source and target branches