Merge lp:~lukas-kde/unity8/nonPixelatedNotificationIcons into lp:unity8

Proposed by Lukáš Tinkl on 2016-11-01
Status: Merged
Approved by: Michael Zanetti on 2016-11-01
Approved revision: 2674
Merged at revision: 2694
Proposed branch: lp:~lukas-kde/unity8/nonPixelatedNotificationIcons
Merge into: lp:unity8
Diff against target: 11 lines (+1/-0)
1 file modified
qml/Notifications/ShapedIcon.qml (+1/-0)
To merge this branch: bzr merge lp:~lukas-kde/unity8/nonPixelatedNotificationIcons
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Approve on 2016-11-01
Michael Zanetti (community) 2016-11-01 Approve on 2016-11-01
Review via email: mp+309740@code.launchpad.net

Commit message

Fix the pixelated notification icon by setting sourceSize

Description of the change

Fix the pixelated icon by setting sourceSize

* Are there any related MPs required for this MP to build/function as expected? Please list.

No

* Did you perform an exploratory manual test run of your code change and any related functionality?

Yes

* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?

N/A

* If you changed the UI, has there been a design review?

N/A

To post a comment you must log in.
Michael Zanetti (mzanetti) wrote :

* Did you perform an exploratory manual test run of the code change and any related functionality?

yes

* Did CI run pass? If not, please explain why.

waiting with top approval for CI to pass

review: Approve
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:2674
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2464/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3238
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1858
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1858
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1858
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3266
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3120/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3120
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3120/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/2464/rebuild

review: Approve (continuous-integration)
2675. By Lukáš Tinkl on 2016-11-07

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Notifications/ShapedIcon.qml'
2--- qml/Notifications/ShapedIcon.qml 2016-04-06 14:24:40 +0000
3+++ qml/Notifications/ShapedIcon.qml 2016-11-07 13:14:19 +0000
4@@ -35,6 +35,7 @@
5
6 objectName: "nonShapedIcon"
7 anchors.fill: parent
8+ sourceSize: Qt.size(parent.width, parent.height)
9 visible: !shaped
10 source: fileSource
11 fillMode: Image.PreserveAspectFit

Subscribers

People subscribed via source and target branches