Ubuntu Settings Components

Merge lp:~lukas-kde/ubuntu-settings-components/rtlFixes into lp:ubuntu-settings-components

  1. rtlFixes
  2. Merge into trunk
Proposed by Lukáš Tinkl
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 170
Merged at revision: 173
Proposed branch: lp:~lukas-kde/ubuntu-settings-components/rtlFixes
Merge into: lp:ubuntu-settings-components
Prerequisite: lp:~3v1n0/ubuntu-settings-components/new-calendar-design
Diff against target: 103 lines (+18/-3)
7 files modified
plugins/Ubuntu/Settings/Components/Calendar.qml (+1/-1)
plugins/Ubuntu/Settings/Components/MessageHeader.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/BaseLayoutMenu.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml (+1/-1)
plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml (+3/-0)
plugins/Ubuntu/Settings/Menus/SliderMenu.qml (+4/-1)
plugins/Ubuntu/Settings/Menus/TransferMenu.qml (+3/-0)
To merge this branch: bzr merge lp:~lukas-kde/ubuntu-settings-components/rtlFixes
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Unity8 CI Bot continuous-integration Approve
Review via email: mp+310180@code.launchpad.net

Commit message

Indicator components fixes for right-to-left languages (RTL)

Apart from the physical prereq, this branch needs:
- u8: https://code.launchpad.net/~lukas-kde/unity8/loadQtCatalog/+merge/309414 (to fix enabling RTL on startup)
- uitk: https://code.launchpad.net/~lukas-kde/ubuntu-ui-toolkit/sliderStyleRTL/+merge/309461 (to fix the progress of any slider component)

Description of the change

Indicator components fixes for right-to-left languages (RTL)

To post a comment you must log in.
Revision history for this message
Unity8 CI Bot (unity8-ci-bot) wrote :

PASSED: Continuous integration, rev:170
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/112/
Executed test runs:
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build/3255
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial+overlay,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=zesty,testname=qmluitests.sh/1863
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/3283
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=zesty/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=zesty/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial+overlay/3137/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3137
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=zesty/3137/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-ubuntu-settings-components-ci/112/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Looks good, a part from that unrelated change which is quite conflicts prone :-)

review: Approve
lp:~lukas-kde/ubuntu-settings-components/rtlFixes updated
171. By Lukáš Tinkl

merge trunk

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Ubuntu/Settings/Components/Calendar.qml'
2--- plugins/Ubuntu/Settings/Components/Calendar.qml 2016-11-15 18:02:22 +0000
3+++ plugins/Ubuntu/Settings/Components/Calendar.qml 2016-11-22 09:56:25 +0000
4@@ -310,7 +310,7 @@
5 readonly property int weekday: (index % priv.days + firstDayOfWeek) % priv.days
6 readonly property var dayStart: gridStart.addDays(index)
7 readonly property bool isSelected: priv.userSelected && dayStart.equals(priv.selectedDay)
8- readonly property bool isCurrentMonth: (monthStart < dayStart || monthStart.equals(dayStart)) && dayStart < monthEnd
9+ readonly property bool isCurrentMonth: (monthStart < dayStart || monthStart.equals(dayStart)) && dayStart < monthEnd
10 readonly property bool isWeekend: weekday == 0 || weekday == 6
11 readonly property bool isToday: dayStart.equals(priv.today)
12 readonly property bool hasEvent: isCurrentMonth && eventDays.indexOf(dayStart.day) != -1
13
14=== modified file 'plugins/Ubuntu/Settings/Components/MessageHeader.qml'
15--- plugins/Ubuntu/Settings/Components/MessageHeader.qml 2016-10-11 11:35:24 +0000
16+++ plugins/Ubuntu/Settings/Components/MessageHeader.qml 2016-11-22 09:56:25 +0000
17@@ -25,6 +25,9 @@
18 Item {
19 id: messageHeader
20
21+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
22+ LayoutMirroring.childrenInherit: true
23+
24 property alias avatar: avatarImage.source
25 property alias icon: iconImage.source
26 property alias time: timeText.text
27
28=== modified file 'plugins/Ubuntu/Settings/Menus/BaseLayoutMenu.qml'
29--- plugins/Ubuntu/Settings/Menus/BaseLayoutMenu.qml 2016-10-05 13:36:10 +0000
30+++ plugins/Ubuntu/Settings/Menus/BaseLayoutMenu.qml 2016-11-22 09:56:25 +0000
31@@ -22,6 +22,9 @@
32 BaseMenu {
33 id: menu
34
35+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
36+ LayoutMirroring.childrenInherit: true
37+
38 property string text
39 property alias layout: layoutItem
40 property alias title: layoutItem.title
41
42=== modified file 'plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml'
43--- plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml 2016-10-26 19:51:29 +0000
44+++ plugins/Ubuntu/Settings/Menus/GroupedMessageMenu.qml 2016-11-22 09:56:25 +0000
45@@ -35,7 +35,7 @@
46 implicitHeight: label.implicitHeight + units.gu(2)
47 implicitWidth: label.implicitWidth + units.gu(2)
48
49- color: theme.palette.normal.backgroundText
50+ color: theme.palette.normal.background
51 radius: "medium"
52
53 Label {
54
55=== modified file 'plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml'
56--- plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml 2016-10-11 11:35:24 +0000
57+++ plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml 2016-11-22 09:56:25 +0000
58@@ -38,6 +38,9 @@
59 objectName: "menuItemInfoSlotsLayout"
60 style: menuStyle
61
62+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
63+ LayoutMirroring.childrenInherit: true
64+
65 mainSlot: ColumnLayout {
66 spacing: units.gu(0.5)
67
68
69=== modified file 'plugins/Ubuntu/Settings/Menus/SliderMenu.qml'
70--- plugins/Ubuntu/Settings/Menus/SliderMenu.qml 2016-10-28 10:23:02 +0000
71+++ plugins/Ubuntu/Settings/Menus/SliderMenu.qml 2016-11-22 09:56:25 +0000
72@@ -103,13 +103,16 @@
73 anchors.topMargin: label.visible ? menuStyle.padding.top : 0
74 spacing: -units.gu(1.5)
75
76+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
77+ LayoutMirroring.childrenInherit: true
78+
79 Label {
80 id: label
81 visible: text != ""
82 color: menu.foregroundColor
83 font.pixelSize: menuStyle.fontSize
84 x: Qt.application.layoutDirection == Qt.LeftToRight ?
85- leftButton.x : rightButton.x + rightButton.width - width
86+ leftButton.x : rightButton.x
87 }
88
89 StyledSlotsLayout {
90
91=== modified file 'plugins/Ubuntu/Settings/Menus/TransferMenu.qml'
92--- plugins/Ubuntu/Settings/Menus/TransferMenu.qml 2016-10-11 11:35:24 +0000
93+++ plugins/Ubuntu/Settings/Menus/TransferMenu.qml 2016-11-22 09:56:25 +0000
94@@ -24,6 +24,9 @@
95 BaseMenu {
96 id: menu
97
98+ LayoutMirroring.enabled: Qt.application.layoutDirection == Qt.RightToLeft
99+ LayoutMirroring.childrenInherit: true
100+
101 property alias iconSource: icon.source
102 property alias text: label.text
103 property alias stateText: stateLabel.text

Subscribers

People subscribed via source and target branches

to all changes: