Merge lp:~lukas-kde/ubuntu-settings-components/hugeNetworkIcons into lp:~registry/ubuntu-settings-components/trunk

[Lukáš Tinkl]

Fix huge icons in network indicator caused by a binding loop

Fix huge icons in network indicator caused by a binding loop

Fixes lp:1585645

[lp:~lukas-kde/ubuntu-settings-components/hugeNetworkIcons]

145. By Lukáš Tinkl on 2016-05-26

also provide the height

for DGU to work correctly

[Albert Astals Cid (aacid)]

The code does indeed seem to fix the problem.

But i can't seem to understand *why* we need it.

I'm going to approve it but it would be very nice if you could try to work on a smaller testcase that shows what is the problem really.

review: Approve

Unmerged revisions

145. By Lukáš Tinkl on 2016-05-26

also provide the height

for DGU to work correctly

144. By Lukáš Tinkl on 2016-05-26

fix huge mobile network icons

=== modified file 'plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml'
--- plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml	2016-05-19 17:52:21 +0000
+++ plugins/Ubuntu/Settings/Menus/ModemInfoItem.qml	2016-05-26 22:33:14 +0000
@@ -77,8 +77,8 @@
                     id: iconConnectivity
                     color: theme.palette.normal.backgroundText
 
-                    height: labelStatus.height
-                    width: height
+                    width: statusIcon.width // fix lp:1585645 by breaking the binding loop
+                    height: width
 
                     visible: name !== ""
                 }