Merge lp:~lukas-kde/ubuntu-settings-components/extractPo into lp:~registry/ubuntu-settings-components/trunk
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Albert Astals Cid on 2015-08-04 | ||||
| Approved revision: | 96 | ||||
| Merged at revision: | 94 | ||||
| Proposed branch: | lp:~lukas-kde/ubuntu-settings-components/extractPo | ||||
| Merge into: | lp:~registry/ubuntu-settings-components/trunk | ||||
| Diff against target: |
180 lines (+110/-5) 7 files modified
CMakeLists.txt (+1/-0) plugins/Ubuntu/Settings/Components/QuickReply.qml (+1/-1) plugins/Ubuntu/Settings/Menus/SnapDecisionMenu.qml (+3/-3) plugins/Ubuntu/Settings/Menus/TextMessageMenu.qml (+1/-1) po/CMakeLists.txt (+33/-0) po/ubuntu-settings-components.pot (+35/-0) po/update-usc-pot (+36/-0) |
||||
| To merge this branch: | bzr merge lp:~lukas-kde/ubuntu-settings-components/extractPo | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | 2015-08-02 | Approve on 2015-08-04 | |
| PS Jenkins bot (community) | continuous-integration | Approve on 2015-08-04 | |
| Registry Administrators | 2015-08-02 | Pending | |
|
Review via email:
|
|||
Commit Message
Setup message extraction, load the catalog from the plugins
Description of the Change
Setup message extraction, load the catalog from the plugins
Until now, the user visible strings haven't been extracted and therefore couldn't be translated.
| Albert Astals Cid (aacid) wrote : | # |
I don't think we should include the Czech translation, should be done via https:/
| Lukáš Tinkl (lukas-kde) wrote : | # |
> I don't think we should include the Czech translation, should be done via
> https:/
> this and configure that page correctly
Fair enough, yup. I'll adjust it
- 95. By Lukáš Tinkl on 2015-08-04
-
don't ship cs.po, rely on launchpad for the translations
| PS Jenkins bot (ps-jenkins) wrote : | # |
PASSED: Continuous integration, rev:95
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild:
http://
| Albert Astals Cid (aacid) wrote : | # |
Thinkign about this, i think this is not the correct solution, calling textdomain will overwrite the text domain set by the application that uses this plugin making its i18n() untranslated.
We should just use i18n.dtr() instead of i18n.tr()
- 96. By Lukáš Tinkl on 2015-08-04
-
use i18n.dtr() instead of overwriting the textdomain

PASSED: Continuous integration, rev:94 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- ci/118/ jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- qmltests- vivid/43 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-amd64- ci/25 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/25 jenkins. qa.ubuntu. com/job/ ubuntu- settings- components- vivid-armhf- ci/25/artifact/ work/output/ *zip*/output. zip
http://
Executed test runs:
SUCCESS: http://
SUCCESS: http://
SUCCESS: http://
deb: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/ubuntu- settings- components- ci/118/ rebuild
http://