Merge lp:~lukas-kde/qtmir/xkbkeys into lp:qtmir
| Status: | Merged |
|---|---|
| Approved by: | Daniel d'Andrada on 2015-07-24 |
| Approved revision: | 346 |
| Merged at revision: | 352 |
| Proposed branch: | lp:~lukas-kde/qtmir/xkbkeys |
| Merge into: | lp:qtmir |
| Diff against target: |
411 lines (+309/-79) 1 file modified
src/platforms/mirserver/qteventfeeder.cpp (+309/-79) |
| To merge this branch: | bzr merge lp:~lukas-kde/qtmir/xkbkeys |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Gerry Boland | Approve on 2015-07-30 | ||
| Daniel d'Andrada (community) | 2015-07-24 | Approve on 2015-07-24 | |
| PS Jenkins bot | continuous-integration | Needs Fixing on 2015-07-24 | |
|
Review via email:
|
|||
Commit Message
Extend the key table to cover full xkb range of keycodes.
Fixes many missing symbols, mainly various multimedia keys.
Also fix missing mapping to back/forward extra mouse buttons.
Description of the Change
Extend the key table to cover full xkb range of keycodes. Fixes many missing symbols, mainly various multimedia keys.
Also fix missing mapping to back/forward extra mouse buttons.
* Are there any related MPs required for this MP to build/function as expected? Please list.
No
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
| Gerry Boland (gerboland) wrote : | # |
+ //XKB_KEY_KP_F1, Qt::Key_F1,
+ //XKB_KEY_KP_F2, Qt::Key_F2,
+ //XKB_KEY_KP_F3, Qt::Key_F3,
+ //XKB_KEY_KP_F4, Qt::Key_F4,
Why commented out? That and several others
| Lukáš Tinkl (lukas-kde) wrote : | # |
> + //XKB_KEY_KP_F1, Qt::Key_F1,
> + //XKB_KEY_KP_F2, Qt::Key_F2,
> + //XKB_KEY_KP_F3, Qt::Key_F3,
> + //XKB_KEY_KP_F4, Qt::Key_F4,
> Why commented out? That and several others
In this case, it looks like the _keypad_ F1 key.... dunno if it's really a valid option. In any case, the mappings are taken from Qt source code, so it should be safe.

FAILED: Continuous integration, rev:346 jenkins. qa.ubuntu. com/job/ qtmir-ci/ 325/ jenkins. qa.ubuntu. com/job/ qtmir-wily- amd64-ci/ 58/console jenkins. qa.ubuntu. com/job/ qtmir-wily- armhf-ci/ 58/console
http://
Executed test runs:
FAILURE: http://
FAILURE: http://
Click here to trigger a rebuild: s-jenkins. ubuntu- ci:8080/ job/qtmir- ci/325/ rebuild
http://