Code review comment for lp:~lukas-kde/qtmir/use-miral-shell-chrome

Revision history for this message
Lukáš Tinkl (lukas-kde) wrote :

> Small nicety I'd appreciate you doing:
>
> connect(m_surfaceObserver.get(), &SurfaceObserver::shellChromeChanged,
> this, [&](MirShellChrome shell_chrome) {
> setShellChrome(static_cast<Mir::ShellChrome>(shell_chrome));
>
> Please use toQtShellChrome instead of the static_cast here

Done, also merged with trunk and resolved conflicts there, now that the silo 2313 had landed

« Back to merge proposal