Merge lp:~lukas-kde/indicator-power/showTimeAndPercentageOptions into lp:indicator-power

Proposed by Lukáš Tinkl on 2016-10-18
Status: Needs review
Proposed branch: lp:~lukas-kde/indicator-power/showTimeAndPercentageOptions
Merge into: lp:indicator-power
Diff against target: 18 lines (+8/-0)
1 file modified
src/service.c (+8/-0)
To merge this branch: bzr merge lp:~lukas-kde/indicator-power/showTimeAndPercentageOptions
Reviewer Review Type Date Requested Status
unity-api-1-bot continuous-integration Approve on 2016-11-17
Indicator Applet Developers 2016-10-18 Pending
Review via email: mp+308718@code.launchpad.net

Commit message

Add show-time and show-percentage actions to the phone profile

Description of the change

Add show-time and show-percentage actions to the phone profile

Brings those options to the phone profile as part of the convergence effort. The phone profile is the default one for unity8, even in desktop scenarios.

To post a comment you must log in.
unity-api-1-bot (unity-api-1-bot) wrote :

PASSED: Continuous integration, rev:299
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-power-ci/3/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build/1097
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-0-fetch/1104
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=xenial+overlay/895/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=amd64,release=zesty/895/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=xenial+overlay/895/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=armhf,release=zesty/895/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=xenial+overlay/895/artifact/output/*zip*/output.zip
    SUCCESS: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/895
        deb: https://jenkins.canonical.com/unity-api-1/job/build-2-binpkg/arch=i386,release=zesty/895/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://jenkins.canonical.com/unity-api-1/job/lp-indicator-power-ci/3/rebuild

review: Approve (continuous-integration)

Unmerged revisions

299. By Lukáš Tinkl on 2016-10-25

merge trunk

298. By Lukáš Tinkl on 2016-10-18

add show-time, show-percentage config actions to phone profile

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/service.c'
2--- src/service.c 2016-05-26 18:21:09 +0000
3+++ src/service.c 2016-10-25 11:50:03 +0000
4@@ -657,6 +657,14 @@
5 g_object_unref(item);
6 }
7
8+ g_menu_append (section,
9+ _("Show Time in Menu Bar"),
10+ "indicator.show-time");
11+
12+ g_menu_append (section,
13+ _("Show Percentage in Menu Bar"),
14+ "indicator.show-percentage");
15+
16 g_menu_append(section, _("Battery settings…"), "indicator.activate-phone-settings");
17
18 return G_MENU_MODEL(section);

Subscribers

People subscribed via source and target branches