Merge lp:~lukas-kde/gsettings-ubuntu-touch-schemas/sanerTouchpadDefaults into lp:gsettings-ubuntu-touch-schemas

Proposed by Lukáš Tinkl on 2016-07-22
Status: Merged
Approved by: Michael Terry on 2016-07-25
Approved revision: 71
Merged at revision: 71
Proposed branch: lp:~lukas-kde/gsettings-ubuntu-touch-schemas/sanerTouchpadDefaults
Merge into: lp:gsettings-ubuntu-touch-schemas
Diff against target: 17 lines (+2/-2)
1 file modified
accountsservice/com.ubuntu.AccountsService.Input.xml (+2/-2)
To merge this branch: bzr merge lp:~lukas-kde/gsettings-ubuntu-touch-schemas/sanerTouchpadDefaults
Reviewer Review Type Date Requested Status
Michael Terry (community) 2016-07-22 Approve on 2016-07-25
Daniel van Vugt (community) Needs Information on 2016-07-25
Review via email: mp+300917@code.launchpad.net

Commit message

Enable TouchpadTwoFingerScroll and TouchpadTapToClick by default

Description of the change

Saner touchpad defaults

Enable TouchpadTwoFingerScroll and TouchpadTapToClick by default

To post a comment you must log in.
Daniel van Vugt (vanvugt) wrote :

I think you incorrectly linked bug 1603183. We do *not* want to fix bug 1603183 with default settings. That should be an option.

Although it sounds like maybe bug 1603183 isn't really being solved here, which would be a good thing.

review: Needs Information
Lukáš Tinkl (lukas-kde) wrote :

In the case of my touchpad, invoking a right click isn't possible at all without TapToClick enabled. :/

Lukáš Tinkl (lukas-kde) wrote :

To expand the above comment, while looking at Mir (and libinput source code), both options can be actually enabled at the same time (tap to click and a single click in the lower right corner), we just don't expose or enable the latter.

Michael Terry (mterry) wrote :

Sure, LGTM.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'accountsservice/com.ubuntu.AccountsService.Input.xml'
2--- accountsservice/com.ubuntu.AccountsService.Input.xml 2016-04-05 17:22:15 +0000
3+++ accountsservice/com.ubuntu.AccountsService.Input.xml 2016-07-22 15:56:47 +0000
4@@ -51,11 +51,11 @@
5 </property>
6
7 <property name="TouchpadTapToClick" type="b" access="readwrite">
8- <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
9+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
10 </property>
11
12 <property name="TouchpadTwoFingerScroll" type="b" access="readwrite">
13- <annotation name="org.freedesktop.Accounts.DefaultValue" value="false"/>
14+ <annotation name="org.freedesktop.Accounts.DefaultValue" value="true"/>
15 </property>
16
17 <property name="TouchpadDisableWithMouse" type="b" access="readwrite">

Subscribers

People subscribed via source and target branches