Merge lp:~lucian.grijincu/software-center/back-forward-with-alt-left-and-alt-right-gnome-hig into lp:software-center

Proposed by Lucian Adrian Grijincu
Status: Merged
Merge reported by: Michael Vogt
Merged at revision: not available
Proposed branch: lp:~lucian.grijincu/software-center/back-forward-with-alt-left-and-alt-right-gnome-hig
Merge into: lp:software-center
Diff against target: 30 lines (+20/-0)
1 file modified
softwarecenter/app.py (+20/-0)
To merge this branch: bzr merge lp:~lucian.grijincu/software-center/back-forward-with-alt-left-and-alt-right-gnome-hig
Reviewer Review Type Date Requested Status
Gary Lasker Pending
Review via email: mp+33989@code.launchpad.net

Description of the change

Add new accelerators to make software-center more GNOME-HIG compliant: Alt-Left, Alt-Right work as back/forward. Closes LP #625745.

To post a comment you must log in.
Revision history for this message
Gary Lasker (gary-lasker) wrote :

Hi Lucian, thanks for your branch. Please check bug 625745 for my comments about this pending fix. Thanks!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'softwarecenter/app.py'
2--- softwarecenter/app.py 2010-08-26 15:26:00 +0000
3+++ softwarecenter/app.py 2010-08-28 11:23:40 +0000
4@@ -325,6 +325,26 @@
5 ord(']'),
6 gtk.gdk.CONTROL_MASK,
7 gtk.ACCEL_VISIBLE)
8+ self.menuitem_go_back.add_accelerator("activate",
9+ accel_group,
10+ gtk.gdk.keyval_from_name("Left"),
11+ gtk.gdk.MOD1_MASK,
12+ gtk.ACCEL_VISIBLE)
13+ self.menuitem_go_forward.add_accelerator("activate",
14+ accel_group,
15+ gtk.gdk.keyval_from_name("Right"),
16+ gtk.gdk.MOD1_MASK,
17+ gtk.ACCEL_VISIBLE)
18+ self.menuitem_go_back.add_accelerator("activate",
19+ accel_group,
20+ gtk.gdk.keyval_from_name("KP_Left"),
21+ gtk.gdk.MOD1_MASK,
22+ gtk.ACCEL_VISIBLE)
23+ self.menuitem_go_forward.add_accelerator("activate",
24+ accel_group,
25+ gtk.gdk.keyval_from_name("KP_Right"),
26+ gtk.gdk.MOD1_MASK,
27+ gtk.ACCEL_VISIBLE)
28
29 # default focus
30 self.available_pane.searchentry.grab_focus()